Skip to content

fix(proto): return error for unsupported custom serialization #1186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fallintoplace wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(proto): return error for unsupported custom serialization #1186

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion proto/column.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -320,7 +320,7 @@ func (s *ColInfoInput) DecodeResult(r *Reader, version int, b Block) error {
return errors.Wrapf(err, "column [%d] custom serialization", i)
}
if customSerialization {
return errors.Wrapf(err, "column [%d] has custom serialization (not supported)", i)
return errors.Errorf("column [%d] has custom serialization (not supported)", i)
}
}
*s = append(*s, ColInfo{
Expand Down
17 changes: 17 additions & 0 deletions proto/column_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,23 @@ func checkWriteColumn(data ColInput) func(*testing.T) {
}
}

func TestColInfoInput_DecodeResult(t *testing.T) {
t.Run("custom serialization", func(t *testing.T) {
var b Buffer
b.PutString("column")
b.PutString("String")
b.PutBool(true)

var got ColInfoInput
err := got.DecodeResult(
b.Reader(),
FeatureCustomSerialization.Version(),
Block{Columns: 1},
)
require.EqualError(t, err, "column [0] has custom serialization (not supported)")
})
}

func TestColumnType_Elem(t *testing.T) {
t.Run("Array", func(t *testing.T) {
v := ColumnTypeInt16.Array()
Expand Down
Loading