Repository navigation
[HDX-5662] feat(app): always use the ClickStack brand - #3545
Conversation
Drop the HyperDX palette and the brand and font pickers so every deployment shares one look. Color mode stays a preference. Fixes HDX-5662. Co-authored-by: Cursor <cursoragent@cursor.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🦋 Changeset detectedLatest commit: d333362 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
🔴 Tier 4 — CriticalTouches authentication, tenancy data models, the public API or shipped database config — or substantially changes the query rendering engine, background tasks, the OTel pipeline, image build, or release CI. Why this tier:
Review process: Deep review from a domain expert. Synchronous walkthrough may be required. Stats
|
Duplicate code analysisNo new duplicate code introduced by this PR. jscpd compared this branch against |
| * declaration handles both themes. */ | ||
| .theme-clickstack input[role='switch'][data-checked='true'] + * { | ||
| * declaration handles both color modes. */ | ||
| input[role='switch'][data-checked='true'] + * { |
There was a problem hiding this comment.
🔵 minor — Switch on-label override loses to Mantine's :checked + .track rule now that the .theme-clickstack prefix is gone
The old selector .theme-clickstack input[role='switch'][data-checked='true'] + * had specificity (0,3,1), which beat Mantine's .input:checked + .track rule at (0,3,0). The new selector input[role='switch'][data-checked='true'] + * is only (0,2,1). Mantine's --switch-text-color: var(--mantine-color-white) therefore wins again, and the white on-label returns on the yellow accent in dark mode, which is the contrast failure the comment above describes. Restore the specificity, for example with html input[role='switch'][data-checked='true'] + * or :root input[role='switch'][data-checked='true'] + *, or by moving the override into Switch.extend in theme/mantineTheme.ts.
Advisory. Fix if it is a small defect in code this PR changes; otherwise reply in the thread. Do not widen the PR or touch files it did not already change. How to respond
| /** Color mode preference (light/dark/system). Separate from brand theme (hyperdx/clickstack). */ | ||
| /** Color mode preference (light/dark/system). */ | ||
| colorMode: ColorModePreference; | ||
| font: 'IBM Plex Mono' | 'Roboto Mono' | 'Inter' | 'Roboto'; |
There was a problem hiding this comment.
🔵 minor — UserPreferences.font is now dead state that nothing reads
After this PR nothing reads userPreferences.font. _app.tsx hardcodes MANTINE_FONT_MAP.Inter, and the font picker in UserPreferencesModal is gone. The field and its default 'IBM Plex Mono' are still persisted to localStorage and asserted in __tests__/useUserPreferences.test.tsx. Remove font from the type and from DEFAULT_PREFERENCES, dropping it from stored values during migration so stale keys don't linger. Then update the tests.
Advisory. Fix if it is a small defect in code this PR changes; otherwise reply in the thread. Do not widen the PR or touch files it did not already change. How to respond
| }, | ||
| }, | ||
| font: { | ||
| name: 'Font', |
There was a problem hiding this comment.
🔵 minor — Storybook still has a UI font switcher for fonts the app can no longer render
The app now always uses Inter (_app.tsx passes MANTINE_FONT_MAP.Inter, and agent_docs/themes.md says the UI font is Inter). The Storybook font global still switches the Mantine fontFamily and --app-font-family to Roboto, IBM Plex Mono and so on, so stories can show configurations users never see. Remove the font toolbar and always pass Inter. That also leaves FONT_VAR_MAP and DEFAULT_FONT_VAR in config/fonts.ts with no callers, so they can be deleted too.
Advisory. Fix if it is a small defect in code this PR changes; otherwise reply in the thread. Do not widen the PR or touch files it did not already change. How to respond
PR Review
3 finding(s): 🔴 0 critical · 🟠 0 major · 🔵 3 minor 3 posted as inline comment(s) on the changed lines. Severity is the reviewer's own estimate and is used for ordering, not filtering. No finding blocks merge automatically; a maintainer decides. |
Deep Review✅ No critical issues found. This is a large but disciplined deletion/refactor (≈3,100 deletions, 413 insertions across ~100 files) that removes the two-brand theme system and always ships the ClickStack brand. The high-risk vectors for this kind of change were checked and are clean:
The findings below are non-blocking. 🟡 P2 -- recommended
🔵 P3 nitpicks (2)
Reviewers (8): ce-correctness-reviewer, ce-adversarial-reviewer, ce-maintainability-reviewer, ce-testing-reviewer, ce-kieran-typescript-reviewer, ce-project-standards-reviewer, ce-agent-native-reviewer, ce-learnings-researcher. Testing gaps: No direct test for the new No finding blocks merge automatically. A maintainer will expect P0/P1 findings in code this PR changes to be fixed; P2/P3 are your call -- fix or reply. Never fix findings about surrounding code here; reply instead. Do not widen the PR. How to respond |
E2E Test Results✅ All tests passed • 463 passed • 1 skipped • 1497s
Tests ran across 4 shards in parallel. |
usePageTitle had no test once the theme provider tests were removed. The unused font preference stays so older saved preferences still parse. Co-authored-by: Cursor <cursoragent@cursor.com>
Addressed in
Kept, and commented on the field. Older saved preferences include |
The app no longer lets users pick a UI font, so stories should not either. Co-authored-by: Cursor <cursoragent@cursor.com>
The collapse control used a left arrow. It now uses the sidebar glyph and flips when the nav is collapsed. Co-authored-by: Cursor <cursoragent@cursor.com>
Stylelint rejects the camelCase custom properties those tokens use. Co-authored-by: Cursor <cursoragent@cursor.com>
Keep the ClickStack brand while taking the saved-search name field and time zone shortcuts from main. Co-authored-by: Cursor <cursoragent@cursor.com>
Already covered in The font preference notes in the same review are already documented on |
## Summary
The ClickStack brand migration still left a few user-facing strings hardcoded as ClickStack or HyperDX. A downstream build that replaces `src/brand/` does not change them. These now go through `useBrandDisplayName` or `usePageTitle`. Doc URLs are unchanged.
- ClickHouse-build banner: "{brand} features…" and the "{brand} docs" link
- `/careers` title, and "Join us to build {brand} at ClickHouse"
- Raw SQL chart help: "{brand} documentation"
- Search syntax reference tooltip: "{brand} search documentation"
Package names, the HyperDX browser SDK, Terraform provider copy, and comments are left as they are.
### Screenshots or video
Not captured in this session. The table is left for a visual check.
| Before | After |
| :----- | :---- |
| Hardcoded ClickStack / HyperDX | Brand display name |
### How to reproduce
**Starting point:** [play.hyperdx.io](https://play.hyperdx.io), or `yarn app:dev:local` connected to the demo server. The ClickHouse-build banner only shows when `IS_CLICKHOUSE_BUILD` is set.
**On `main`:**
1. Open `/careers`. The document title is "Careers | HyperDX" and the intro says "build ClickStack".
2. Open Search, then the help icon labeled "Open syntax reference". The external-link tooltip says "ClickStack search documentation".
3. Open Chart Explorer on a raw SQL chart and expand "SQL Chart Instructions". The link says "ClickStack documentation".
4. In a ClickHouse build, the top banner says "lacking core ClickStack features" and links "ClickStack Docs".
**On this branch:**
1. Repeat the same steps. Each of those names is the brand display name (ClickStack in this repo).
### How to test on Vercel preview
**Preview routes:** /careers, /search, /chart
**Steps:**
1. Open /careers and confirm the intro says the brand name rather than a hardcoded "ClickStack", and the tab title is "Careers - {brand}".
2. Open /search, click the search help icon ("Open syntax reference"), and hover the external-link icon. Confirm the tooltip uses the brand name.
3. Open /chart, switch to a raw SQL chart, expand "SQL Chart Instructions", and confirm the documentation link uses the brand name.
### References
- Related PRs: #3545
- Linear Issue:
Made with [Cursor](https://cursor.com)
Summary
The app always looks like ClickStack. Deployments and users can no longer pick a HyperDX brand, palette, or UI font. Light, dark, and system color mode stay in User preferences.
Name, page titles, and logos live in
packages/app/src/brand/. A downstream build replaces that folder and keeps the same hook call sites. Colors stay inpackages/app/src/theme/and are not brand-specific. The app switcher is not part of this repo.Screenshots or video
Screenshots were not captured in this session. Please add before (
main) and after (this branch) of the nav logo and User preferences, same viewport and color mode.How to reproduce
Starting point: Vercel preview for this PR, or
yarn app:dev:localconnected to the demo server.On
main:On this branch:
How to test on Vercel preview
Preview routes: /search
Steps:
References
Fixes HDX-5662.