Repository navigation
feat(mcp): support savedFilterValues in dashboard tools - #3533
Conversation
🦋 Changeset detectedLatest commit: b4f22b1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🔵 Tier 2 — Low RiskSmall, isolated change with no API route or data model modifications. Why this tier:
Review process: AI review + quick human skim (target: 5–15 min). Reviewer validates AI assessment and checks for domain-specific concerns. Stats
|
Duplicate code analysis1 new clone introduced by this PR.
If one of these duplicates a helper that already exists, import it instead jscpd compared this branch against |
PR Review
3 finding(s): 🔴 0 critical · 🟠 1 major · 🔵 2 minor 2 posted as inline comment(s) on the changed lines. 1 listed below. Findings outside the changed lines1 minor
Severity is the reviewer's own estimate and is used for ordering, not filtering. No finding blocks merge automatically; a maintainer decides. |
Deep ReviewScope: 6 production files + 1 test file under 🔴 P0/P1 — must fix
🟡 P2 — recommended
🔵 P3 nitpicks (1)
Reviewers (7): correctness, testing, maintainability, project-standards, kieran-typescript, api-contract, previous-comments. Testing gaps: No coverage that hidden Note: Prior-round bot comments claim a No finding blocks merge automatically. A maintainer will expect P0/P1 findings in code this PR changes to be fixed; P2/P3 are your call -- fix or reply. Never fix findings about surrounding code here; reply instead. Do not widen the PR. How to respond |
E2E Test Results✅ All tests passed • 459 passed • 1 skipped • 1638s
Tests ran across 4 shards in parallel. |
|
Addressed the review findings in commits 4789d39d2 and 943405a70:
All 111 saveDashboard + 28 patchDashboard integration tests and the api unit suite pass locally. |
943405a to
33c4cb0
Compare
|
Round 2 responses (commit 2e66b6f5a):
Replying, not changing (out of scope / pre-existing):
This is the second round of automated findings, so per AGENTS.md I'll stop here and defer remaining advisory items to a maintainer's scope review. The failing CI check (E2E Shard 4) is an infra flake — the Next.js Verification: |
2e66b6f to
b4f22b1
Compare
|
Re the P0s - adhoc filters are not supported in external API or MCP yet, and are behind a toggle. This gap will naturally be closed when the external api and MCP schemas are updated to support them. |
Summary
The MCP dashboard tools could not set a dashboard's
savedFilterValues(the default filter selections restored every time a dashboard opens). Theclickstack_save_dashboardnow supports reading and writing these values.How to reproduce
Ask your MCP enabled agent to create a dashboard with some saved filter values
Observe that they're showing when you open the dashboard:
References