Repository navigation
fix(app): bump next to 16.4.3 to fix flaky Google Fonts builds - #3524
Conversation
Google Fonts intermittently returns extensionless /l/font?kit= URLs, which next@16.4.2's font loader can't parse, failing the build with "Cannot read properties of null (reading '1')". Fixed upstream in vercel/next.js#100158, shipped in 16.4.3.
🦋 Changeset detectedLatest commit: b8770b1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🔵 Tier 2 — Low RiskSmall, isolated change with no API route or data model modifications. Why this tier:
Review process: AI review + quick human skim (target: 5–15 min). Reviewer validates AI assessment and checks for domain-specific concerns. Stats
|
PR Review✅ No issues found. |
Duplicate code analysisNo new duplicate code introduced by this PR. jscpd compared this branch against |
Deep Review✅ No critical issues found. This is a patch-level dependency bump of No P0/P1/P2 findings. Two advisory observations are recorded below for awareness; neither is a defect introduced by this diff and neither requires a change.
Reviewers (2): ce-correctness-reviewer, ce-web-researcher. Reviewer set was right-sized to the diff: because the change is a non-executable manifest/lockfile/changeset bump with no source edits, the runtime-behavior lenses (security, performance, reliability, agent-native, testing, maintainability) had no executable code to evaluate and were not fanned out. The previous-comments lens was not run — the two prior PR comments are both automated bot output (changeset-bot, vercel-bot) with no human feedback to verify. Testing gaps: The upstream font-loader fix cannot be exercised on demand (the failure depends on Google's intermittent response), and the fix binary could not be verified in this checkout; confirm against the 16.4.3 release notes rather than relying on the build passing once. |
E2E Test Results✅ All tests passed • 460 passed • 1 skipped • 1332s
Tests ran across 4 shards in parallel. |
Summary
Bumps
nextfrom 16.4.2 to 16.4.3 to fix an intermittentnext buildfailure that hit the nightly release (failed job):Google Fonts sometimes (~1–2% of responses) returns extensionless font URLs (
https://fonts.gstatic.com/l/font?kit=...) instead of.../*.woff2. In 16.4.2 the loader gets the file extension with/\.(woff|woff2|...)$/.exec(url)[1], which throws on those URLs. The response is a 200, so Next's retry never runs.src/fonts.tsloads four Google font families, and each nightly builds the app image six times, so the odds of hitting this on any given night are high. A rerun usually passes.Upstream issue: vercel/next.js#99114. The fix in vercel/next.js#100158 first shipped in 16.4.3. It falls back to the CSS
format('woff2')hint, then towoff2.Why not 16.4.4: our
npmMinimalAgeGate: 7dstill quarantines it, and it contains no font changes. Next's November security release is expected shortly and should be its own bump.The lockfile diff only touches
nextand its@next/*packages.How to reproduce
The failure depends on Google's response, so it can't be triggered on demand. The upstream issue includes an offline repro that uses
NEXT_FONT_GOOGLE_MOCKED_RESPONSES.On this branch:
yarn workspace @hyperdx/common-utils run build && yarn workspace @hyperdx/app run buildsucceeds (webpack).node_modules/next/dist/compiled/@next/font/dist/google/find-font-files-in-css.jscontains theformatToExtensionfallback.How to test on Vercel preview
N/A: no UI change.
References