Skip to content

fix(app): bump next to 16.4.3 to fix flaky Google Fonts builds - #3524

Merged
kodiakhq[bot] merged 2 commits into
mainfrom
warren/fix-flaky-nightly-build
Nov 3, 2026
Merged

kodiakhq[bot] merged 2 commits into
mainfrom
warren/fix-flaky-nightly-build

Conversation

@wrn14897

@wrn14897 wrn14897 commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

Summary

Bumps next from 16.4.2 to 16.4.3 to fix an intermittent next build failure that hit the nightly release (failed job):

src/fonts.ts
An error occurred in `next/font`.
TypeError: Cannot read properties of null (reading '1')
    at next/dist/compiled/@next/font/dist/google/loader.js:122:78

Google Fonts sometimes (~1–2% of responses) returns extensionless font URLs (https://fonts.gstatic.com/l/font?kit=...) instead of .../*.woff2. In 16.4.2 the loader gets the file extension with /\.(woff|woff2|...)$/.exec(url)[1], which throws on those URLs. The response is a 200, so Next's retry never runs. src/fonts.ts loads four Google font families, and each nightly builds the app image six times, so the odds of hitting this on any given night are high. A rerun usually passes.

Upstream issue: vercel/next.js#99114. The fix in vercel/next.js#100158 first shipped in 16.4.3. It falls back to the CSS format('woff2') hint, then to woff2.

Why not 16.4.4: our npmMinimalAgeGate: 7d still quarantines it, and it contains no font changes. Next's November security release is expected shortly and should be its own bump.

The lockfile diff only touches next and its @next/* packages.

How to reproduce

The failure depends on Google's response, so it can't be triggered on demand. The upstream issue includes an offline repro that uses NEXT_FONT_GOOGLE_MOCKED_RESPONSES.

On this branch:

  1. yarn workspace @hyperdx/common-utils run build && yarn workspace @hyperdx/app run build succeeds (webpack).
  2. node_modules/next/dist/compiled/@next/font/dist/google/find-font-files-in-css.js contains the formatToExtension fallback.

How to test on Vercel preview

N/A: no UI change.

References

Google Fonts intermittently returns extensionless /l/font?kit= URLs, which
next@16.4.2's font loader can't parse, failing the build with
"Cannot read properties of null (reading '1')". Fixed upstream in
vercel/next.js#100158, shipped in 16.4.3.
@wrn14897
wrn14897 requested a review from a team as a code owner November 3, 2026 03:18
@wrn14897
wrn14897 requested a review from pulpdrew November 3, 2026 03:18
@changeset-bot

changeset-bot Bot commented Nov 3, 2026 •

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: b8770b1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@hyperdx/app Patch
@hyperdx/api Patch
@hyperdx/otel-collector Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercel Bot commented Nov 3, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
hyperdx-oss Ready Ready Preview Nov 3, 2026 11:51am UTC
hyperdx-storybook Ready Ready Preview Nov 3, 2026 11:51am UTC

Request Review

@github-actions github-actions Bot added the review/tier-2 Low risk — AI review + quick human skim label Nov 3, 2026
@github-actions

github-actions Bot commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

🔵 Tier 2 — Low Risk

Small, isolated change with no API route or data model modifications.

Why this tier:

  • Standard feature/fix — introduces new logic or modifies core functionality

Review process: AI review + quick human skim (target: 5–15 min). Reviewer validates AI assessment and checks for domain-specific concerns.
SLA: Resolve within 4 business hours.

Stats
  • Production files changed: 1
  • Production lines changed: 2
  • Branch: warren/fix-flaky-nightly-build
  • Author: wrn14897

To override this classification, remove the review/tier-2 label and apply a different review/tier-* label. Manual overrides are preserved on subsequent pushes.

@github-actions

github-actions Bot commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

PR Review

✅ No issues found.

@github-actions

github-actions Bot commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

Duplicate code analysis

No new duplicate code introduced by this PR.


jscpd compared this branch against origin/main
across app, api and common-utils. Only new clones are listed; the codebase
currently holds 114 in total (1.41%).
Run yarn dupes locally to reproduce, or yarn dupes:all for the full picture.

@github-actions

github-actions Bot commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

Deep Review

✅ No critical issues found.

This is a patch-level dependency bump of next (^16.4.2 → ^16.4.3) scoped to packages/app. The diff touches three non-executable files — .changeset/next-font-extensionless-urls.md (new), packages/app/package.json, and yarn.lock — with no source-code changes. Verified: the yarn.lock delta is confined to next and @next/* entries only (86 lines, all next-scoped, no collateral package movement), the manifest range ^16.4.3 matches the lockfile descriptor resolving to 16.4.3, no stale 16.4.2 references remain, and the changeset correctly marks @hyperdx/app as patch with a fix: prefix consistent with the other changesets in .changeset/.

No P0/P1/P2 findings. Two advisory observations are recorded below for awareness; neither is a defect introduced by this diff and neither requires a change.

  • Release coupling (informational): @hyperdx/app sits in a changesets fixed group with @hyperdx/api and @hyperdx/otel-collector (.changeset/config.json), so this patch changeset version-bumps all three packages together on release. This is configured, intended behavior — it also explains the changeset-bot comment listing three packages — not a defect.
  • External verification gap (coverage): the upstream claim that 16.4.3 contains the next/font extensionless-URL fix (and introduces no breaking changes vs. 16.4.2) could not be confirmed in this checkout — web access was denied and node_modules/next is not installed, so neither the published changelog nor the compiled find-font-files-in-css.js fallback could be inspected. Worth a glance at the 16.4.3 release notes before merge to confirm no unrelated behavior changes ride along.

Reviewers (2): ce-correctness-reviewer, ce-web-researcher.

Reviewer set was right-sized to the diff: because the change is a non-executable manifest/lockfile/changeset bump with no source edits, the runtime-behavior lenses (security, performance, reliability, agent-native, testing, maintainability) had no executable code to evaluate and were not fanned out. The previous-comments lens was not run — the two prior PR comments are both automated bot output (changeset-bot, vercel-bot) with no human feedback to verify.

Testing gaps: The upstream font-loader fix cannot be exercised on demand (the failure depends on Google's intermittent response), and the fix binary could not be verified in this checkout; confirm against the 16.4.3 release notes rather than relying on the build passing once.

@github-actions

github-actions Bot commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

E2E Test Results

✅ All tests passed • 460 passed • 1 skipped • 1332s

Status Count
✅ Passed 460
❌ Failed 0
⚠️ Flaky 2
⏭️ Skipped 1

Tests ran across 4 shards in parallel.

View full report →

@kodiakhq
kodiakhq Bot merged commit 9df8b8d into main Nov 3, 2026
28 checks passed
@kodiakhq
kodiakhq Bot deleted the warren/fix-flaky-nightly-build branch November 3, 2026 11:56

This branch was successfully deployed

2 active deployments
Preview – hyperdx-oss — b8770b1f Deployed Nov 3, 2026 by vercel[bot]
Preview – hyperdx-storybook — b8770b1f Deployed Nov 3, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automerge review/tier-2 Low risk — AI review + quick human skim

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants