Repository navigation
fix: pin bundled ClickHouse to 26.8.36.3 for security fix - #3497
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🦋 Changeset detectedLatest commit: cfbc147 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
🔵 Tier 2 — Low RiskSmall, isolated change with no API route or data model modifications. Why this tier:
Additional context: touches background tasks or the delivery pipeline lightly (2 lines, under the 30-line bar for Tier 4) Review process: AI review + quick human skim (target: 5–15 min). Reviewer validates AI assessment and checks for domain-specific concerns. Stats
|
PR Review
1 finding(s): 🔴 0 critical · 🟠 0 major · 🔵 1 minor None could be anchored to changed lines; they are listed below. Findings outside the changed lines1 minor
Severity is the reviewer's own estimate and is used for ordering, not filtering. No finding blocks merge automatically; a maintainer decides. |
Duplicate code analysisNo new duplicate code introduced by this PR. jscpd compared this branch against |
[Medium impact] The PR appears safe to merge; no actionable issues were found. SummaryPins bundled ClickHouse and all four changed Docker Compose setups to
Reviews (1) · Last reviewed commit: "fix: pin bundled ClickHouse to 26.8.36.3..." · Reviewed by Greptile |
Deep Review✅ No critical issues found. This is a clean, mechanical version pin. All five references ( 🔵 P3 nitpicks (1)
Reviewers (5): correctness, security, reliability, project-standards, maintainability. Testing gaps:
No finding blocks merge automatically. A maintainer will expect P0/P1 findings in code this PR changes to be fixed; P2/P3 are your call -- fix or reply. Never fix findings about surrounding code here; reply instead. Do not widen the PR. How to respond |
E2E Test Results✅ All tests passed • 461 passed • 1 skipped • 1833s
Tests ran across 4 shards in parallel. |
Summary
Pins the bundled ClickHouse image from the floating
26.8-alpinetag to26.8.36.3-alpine(the patched 26.8 LTS build) because of a ClickHouse security incident.docker/hyperdx/Dockerfile:CLICKHOUSE_VERSION=26.8.36.3(all-in-one image)docker-compose.yml,docker-compose.dev.yml,docker-compose.ci.yml,packages/app/tests/e2e/docker-compose.yml26.8-alpinealready resolves to the same digest as26.8.36.3-alpine(sha256:f5443f9f…, pushed 2026-10-26). Pinning makes the fix explicit and stops a cached or older tag from serving a vulnerable build. Images published before 2026-10-26 still contain the old ClickHouse, so this needs a release to rebuild the all-in-one image.No other ClickHouse lines on the advisory (26.3, 26.9, 26.10) are used here. The otel-collector smoke test stays on
25.12-alpine.How to reproduce
Starting point: local checkout
On
main:docker run --rm clickhouse/clickhouse-server:26.8-alpine clickhouse-server --versionreports whatever the tag currently points at (unpinned).On this branch:
docker build -f docker/hyperdx/Dockerfile --target all-in-one-noauth ...builds, andclickhouse-client -q "SELECT version()"inside the container returns26.8.36.3.Spot-tested locally against 26.8.36.3:
prometheus.int.test.ts+controllers/__tests__): 199/199 pass/healthOK, app serves, schema seededHow to test on Vercel preview
N/A — non-UI change
References