Skip to content

fix: pin bundled ClickHouse to 26.8.36.3 for security fix - #3497

Merged
kodiakhq[bot] merged 2 commits into
mainfrom
brandon/bump-clickhouse-26.8.36.3
Oct 30, 2026
Merged

kodiakhq[bot] merged 2 commits into
mainfrom
brandon/bump-clickhouse-26.8.36.3

Conversation

@brandon-pereira

Copy link
Copy Markdown
Member

Summary

Pins the bundled ClickHouse image from the floating 26.8-alpine tag to 26.8.36.3-alpine (the patched 26.8 LTS build) because of a ClickHouse security incident.

  • docker/hyperdx/Dockerfile: CLICKHOUSE_VERSION=26.8.36.3 (all-in-one image)
  • docker-compose.yml, docker-compose.dev.yml, docker-compose.ci.yml, packages/app/tests/e2e/docker-compose.yml

26.8-alpine already resolves to the same digest as 26.8.36.3-alpine (sha256:f5443f9f…, pushed 2026-10-26). Pinning makes the fix explicit and stops a cached or older tag from serving a vulnerable build. Images published before 2026-10-26 still contain the old ClickHouse, so this needs a release to rebuild the all-in-one image.

No other ClickHouse lines on the advisory (26.3, 26.9, 26.10) are used here. The otel-collector smoke test stays on 25.12-alpine.

How to reproduce

Starting point: local checkout

On main:

  1. docker run --rm clickhouse/clickhouse-server:26.8-alpine clickhouse-server --version reports whatever the tag currently points at (unpinned).

On this branch:

  1. docker build -f docker/hyperdx/Dockerfile --target all-in-one-noauth ... builds, and clickhouse-client -q "SELECT version()" inside the container returns 26.8.36.3.

Spot-tested locally against 26.8.36.3:

  • common-utils integration: 149/149 pass
  • api integration (prometheus.int.test.ts + controllers/__tests__): 199/199 pass
  • all-in-one image builds and boots: API /health OK, app serves, schema seeded

How to test on Vercel preview

N/A — non-UI change

References

  • Linear Issue:
  • Related PRs:

@vercel

vercel Bot commented Oct 30, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
hyperdx-oss Ready Ready Preview Oct 30, 2026 1:04pm UTC
hyperdx-storybook Ready Ready Preview Oct 30, 2026 1:04pm UTC

Request Review

@changeset-bot

changeset-bot Bot commented Oct 30, 2026 •

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: cfbc147

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@hyperdx/api Patch
@hyperdx/app Patch
@hyperdx/otel-collector Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions Bot added the review/tier-2 Low risk — AI review + quick human skim label Oct 30, 2026
@github-actions

Copy link
Copy Markdown
Contributor

🔵 Tier 2 — Low Risk

Small, isolated change with no API route or data model modifications.

Why this tier:

  • Standard feature/fix — introduces new logic or modifies core functionality

Additional context: touches background tasks or the delivery pipeline lightly (2 lines, under the 30-line bar for Tier 4)

Review process: AI review + quick human skim (target: 5–15 min). Reviewer validates AI assessment and checks for domain-specific concerns.
SLA: Resolve within 4 business hours.

Stats
  • Production files changed: 4
  • Production lines changed: 8 (+ 2 in test files, excluded from tier calculation)
  • Branch: brandon/bump-clickhouse-26.8.36.3
  • Author: brandon-pereira

To override this classification, remove the review/tier-2 label and apply a different review/tier-* label. Manual overrides are preserved on subsequent pushes.

@github-actions

Copy link
Copy Markdown
Contributor

PR Review

If you are a coding agent acting for the author, read this first.
Nothing below blocks merge automatically; a maintainer decides. What they will expect:

  • 🔴 critical or 🟠 major in code this PR adds or changes: fix before asking for review.
  • 🔵 minor in code this PR changes: your call. Fix if small, otherwise reply.
  • Anything about surrounding code, or asking you to widen the change (hoist a helper,
    dedupe with another file, fix other call sites): never fix here, whatever the
    severity. Reply with one sentence; if it is critical, say so plainly so a human sees it.

One commit per review round. After two rounds, stop and ask a maintainer to review
scope rather than addressing more automated findings. Full rule: AGENTS.md.

1 finding(s): 🔴 0 critical · 🟠 0 major · 🔵 1 minor

None could be anchored to changed lines; they are listed below.

Findings outside the changed lines

1 minor
  • 🔵 .github/workflows/docker-build.yml:13 — Workflow comment still says the Dockerfile uses a floating ClickHouse tag → .github/workflows/docker-build.yml:12-20 (outside this diff) says the Dockerfile uses floating tags that include clickhouse-server:${CLICKHOUSE_VERSION}-alpine, and gives that as the reason main builds every time. With CLICKHOUSE_VERSION=26.8.36.3, that example is now out of date. Change the comment to say ClickHouse is pinned to a patch release, and keep the 26.8-alpine story as history. Otherwise the next person to bump the version may think pinning the tag is pointless and go back to 26.8.

Severity is the reviewer's own estimate and is used for ordering, not filtering. No finding blocks merge automatically; a maintainer decides.

@github-actions

Copy link
Copy Markdown
Contributor

Duplicate code analysis

No new duplicate code introduced by this PR.


jscpd compared this branch against origin/main
across app, api and common-utils. Only new clones are listed; the codebase
currently holds 114 in total (1.40%).
Run yarn dupes locally to reproduce, or yarn dupes:all for the full picture.

@greptile-apps

greptile-apps Bot commented Oct 30, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The PR appears safe to merge; no actionable issues were found.

Summary

Pins bundled ClickHouse and all four changed Docker Compose setups to 26.8.36.3-alpine. Adds a patch changeset for the shared release group.

  • HyperDX's bundled and Compose ClickHouse servers use the fixed 26.8.36.3 build.

Reviews (1) · Last reviewed commit: "fix: pin bundled ClickHouse to 26.8.36.3..." · Reviewed by Greptile

@github-actions

Copy link
Copy Markdown
Contributor

Deep Review

✅ No critical issues found.

This is a clean, mechanical version pin. All five references (docker-compose.yml, docker-compose.dev.yml, docker-compose.ci.yml, packages/app/tests/e2e/docker-compose.yml, and the ARG CLICKHOUSE_VERSION in docker/hyperdx/Dockerfile) resolve consistently to clickhouse/clickhouse-server:26.8.36.3-alpine, the Dockerfile ARG composes correctly into the FROM at docker/hyperdx/Dockerfile:150, and the single @hyperdx/api changeset correctly bumps all three lockstep packages via the fixed group in .changeset/config.json. The changeset format matches repo conventions, and .github/workflows/docker-build.yml does not override CLICKHOUSE_VERSION, so the new default reaches the rebuilt all-in-one image.

🔵 P3 nitpicks (1)
  • docker/hyperdx/Dockerfile:11 — The image is pinned by version tag (26.8.36.3-alpine) rather than by immutable digest, so an upstream re-push of the same tag could still alter the resolved image; the tag pin resolves the incident and this is a known supply-chain tradeoff.
    • Fix: Optionally pin by digest (clickhouse/clickhouse-server@sha256:...) in the Dockerfile and compose files for a fully immutable reference, accepting reduced patch-visibility.

Reviewers (5): correctness, security, reliability, project-standards, maintainability.

Testing gaps:

  • No automated check keeps the four compose files and the Dockerfile ARG CLICKHOUSE_VERSION in sync on future bumps, so drift can reappear (as it already has with the intentionally-separate smoke-tests/otel-collector/docker-compose.yaml at 25.12-alpine).
  • No CI step confirms the pinned tag 26.8.36.3-alpine resolves from the registry before a release build depends on it.

No finding blocks merge automatically. A maintainer will expect P0/P1 findings in code this PR changes to be fixed; P2/P3 are your call -- fix or reply. Never fix findings about surrounding code here; reply instead. Do not widen the PR. How to respond

@github-actions

github-actions Bot commented Oct 30, 2026 •

Copy link
Copy Markdown
Contributor

E2E Test Results

✅ All tests passed • 461 passed • 1 skipped • 1833s

Status Count
✅ Passed 461
❌ Failed 0
⚠️ Flaky 1
⏭️ Skipped 1

Tests ran across 4 shards in parallel.

View full report →

@kodiakhq
kodiakhq Bot merged commit f2b8986 into main Oct 30, 2026
28 of 29 checks passed
@kodiakhq
kodiakhq Bot deleted the brandon/bump-clickhouse-26.8.36.3 branch October 30, 2026 13:11

This branch was successfully deployed

2 active deployments
Preview – hyperdx-oss — cfbc1475 Deployed Oct 30, 2026 by vercel[bot]
Preview – hyperdx-storybook — cfbc1475 Deployed Oct 30, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automerge review/tier-2 Low risk — AI review + quick human skim

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants