Repository navigation
chore: Make common-utils type checking faster - #3486
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
🔵 Tier 2 — Low RiskSmall, isolated change with no API route or data model modifications. Why this tier:
Review process: AI review + quick human skim (target: 5–15 min). Reviewer validates AI assessment and checks for domain-specific concerns. Stats
|
Duplicate code analysisNo new duplicate code introduced by this PR. jscpd compared this branch against |
PR Review
1 finding(s): 🔴 0 critical · 🟠 0 major · 🔵 1 minor None could be anchored to changed lines; they are listed below. Findings outside the changed lines1 minor
Severity is the reviewer's own estimate and is used for ordering, not filtering. No finding blocks merge automatically; a maintainer decides. |
[Medium impact] The PR appears safe to merge; no actionable issues were found. SummaryMoves declaration generation for
No actionable issues were found. Builds were not run. Reviews (1) · Last reviewed commit: "chore: Make common-utils type checking f..." · Reviewed by Greptile |
Deep Review✅ No critical issues found. This is a low-risk build-config change: Verified sound during review:
🔵 P3 nitpicks (1)
Reviewers (6): correctness, testing, maintainability, project-standards, api-contract, kieran-typescript. Testing gaps: No automated check asserts that every consumer deep-import path (e.g. No finding blocks merge automatically. A maintainer will expect P0/P1 findings in code this PR changes to be fixed; P2/P3 are your call -- fix or reply. Never fix findings about surrounding code here; reply instead. Do not widen the PR. How to respond |
E2E Test Results✅ All tests passed • 458 passed • 1 skipped • 1886s
Tests ran across 4 shards in parallel. |
Summary
Generates
@hyperdx/common-utilstype declarations withtsc+tsc-aliasinstead of tsup's DTS bundler. The bundler (rollup-plugin-dts) takes about 3× the time and memory.packages/common-utilsmainyarn build(Docker/CI)yarn dev:build(yarn dev)Changes:
tsup.config.ts:dts: false. This also drops theignoreDeprecationsworkaround for thebaseUrlthat tsup's DTS bundler injected.tsconfig.build.json(new): emits declarations only and excludes tests.package.json:buildrunstsup && yarn build:types.dev:buildandci:buildcallbuild. Before,dev:buildran tsup's DTS and then overwrote it withtscoutput, so local dev already usedtsc-emitted declarations.src/core/handlebarsEnv.ts:HandlebarsTemplateDelegate→Handlebars.TemplateDelegate. The global name madetscemit a.d.tsthat never imports handlebars.