Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,10 @@
<a href="https://trendshift.io/repositories/2030?utm_source=repository-badge&utm_medium=badge&utm_campaign=badge-repository-2030" target="_blank" rel="noopener noreferrer"><img src="https://trendshift.io/api/badge/repositories/2030" alt="hyperdxio%2Fhyperdx | Trendshift" width="250" height="55"/></a>
</p>

<p align="center">

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 minor — The badge image is hotlinked from a third-party server that can change it at any time

<img src="https://app.railyard.run/deploy/badge"> is served live by an unaffiliated vendor. They can change what it shows whenever they like, and every view of the README sends a request to their server. It also sits above the project description, so it reads as an official endorsement, while the 'production deployment' text a few lines down sends users to the ClickStack docs instead. If maintainers want the link, commit the badge as a static asset (or use plain text) and move it into the deployment section next to the existing options.

Advisory. Fix if it is a small defect in code this PR changes; otherwise reply in the thread. Do not widen the PR or touch files it did not already change. How to respond

<a href="https://app.railyard.run/deploy?repo=https://github.com/hyperdxio/hyperdx"><img src="https://app.railyard.run/deploy/badge" alt="Deploy to Railyard"></a>

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟠 major — Deploy link only passes the repo URL, but the repo has no root Dockerfile

The PR says Railyard deploys by reading the repo's Dockerfile, but the repo root has none. The Dockerfiles are docker/hyperdx/Dockerfile (multi-stage, with targets prod, all-in-one-noauth and all-in-one-auth), packages/api/Dockerfile and packages/app/Dockerfile, plus a multi-service docker-compose.yml. With nothing but ?repo=... in the URL, the button either fails or builds an image the maintainers didn't choose (for example, the last stage all-in-one-auth, which builds ClickHouse, the OTel collector and Node from source). Before merging, test the flow against this repo and add the Dockerfile path and build target to the link, or drop the button and keep pointing users to the documented docker run ... hyperdx-all-in-one image and the deployment docs.

Nothing blocks merge automatically, but a maintainer will expect this fixed if it is a real defect in code this PR changes. If it is about surrounding code, reply and say so instead of patching. Do not widen the PR. How to respond

</p>

[HyperDX](https://hyperdx.io), a core component of
[ClickStack](https://clickhouse.com/use-cases/observability), helps engineers
quickly figure out why production is broken by making it easy to search &
Expand Down
Loading