Repository navigation
Add a one-click deploy button for Railyard #3463
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -17,6 +17,10 @@ | |
| <a href="https://trendshift.io/repositories/2030?utm_source=repository-badge&utm_medium=badge&utm_campaign=badge-repository-2030" target="_blank" rel="noopener noreferrer"><img src="https://trendshift.io/api/badge/repositories/2030" alt="hyperdxio%2Fhyperdx | Trendshift" width="250" height="55"/></a> | ||
| </p> | ||
|
|
||
| <p align="center"> | ||
| <a href="https://app.railyard.run/deploy?repo=https://github.com/hyperdxio/hyperdx"><img src="https://app.railyard.run/deploy/badge" alt="Deploy to Railyard"></a> | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🟠 major — Deploy link only passes the repo URL, but the repo has no root Dockerfile The PR says Railyard deploys by reading the repo's Dockerfile, but the repo root has none. The Dockerfiles are Nothing blocks merge automatically, but a maintainer will expect this fixed if it is a real defect in code this PR changes. If it is about surrounding code, reply and say so instead of patching. Do not widen the PR. How to respond |
||
| </p> | ||
|
|
||
| [HyperDX](https://hyperdx.io), a core component of | ||
| [ClickStack](https://clickhouse.com/use-cases/observability), helps engineers | ||
| quickly figure out why production is broken by making it easy to search & | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔵 minor — The badge image is hotlinked from a third-party server that can change it at any time
<img src="https://app.railyard.run/deploy/badge">is served live by an unaffiliated vendor. They can change what it shows whenever they like, and every view of the README sends a request to their server. It also sits above the project description, so it reads as an official endorsement, while the 'production deployment' text a few lines down sends users to the ClickStack docs instead. If maintainers want the link, commit the badge as a static asset (or use plain text) and move it into the deployment section next to the existing options.Advisory. Fix if it is a small defect in code this PR changes; otherwise reply in the thread. Do not widen the PR or touch files it did not already change. How to respond