Repository navigation
chore(deps): bump zod from 3.25.76 to 4.6.6 #3459
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -100,7 +100,7 @@ | |
| "timestamp-nano": "^1.0.1", | ||
| "uplot": "^1.6.31", | ||
| "uplot-react": "^1.2.2", | ||
| "zod": "3.25" | ||
| "zod": "4.6" | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🔴 critical — @hookform/resolvers 3.9.0 can't handle zod 4 errors, so form validation throws instead of showing field errors Before or alongside this bump, upgrade Nothing blocks merge automatically, but a maintainer will expect this fixed if it is a real defect in code this PR changes. If it is about surrounding code, reply and say so instead of patching. Do not widen the PR. How to respond |
||
| }, | ||
| "devDependencies": { | ||
| "@chromatic-com/storybook": "^4.1.3", | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -26,7 +26,7 @@ | |
| "object-hash": "^3.0.0", | ||
| "sql-formatter": "^15.7.2", | ||
| "sqlstring": "^2.3.3", | ||
| "zod": "3.25" | ||
| "zod": "4.6" | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🟠 major — A major zod upgrade with no code migration: every About 108 files import from Nothing blocks merge automatically, but a maintainer will expect this fixed if it is a real defect in code this PR changes. If it is about surrounding code, reply and say so instead of patching. Do not widen the PR. How to respond |
||
| }, | ||
| "devDependencies": { | ||
| "@stryker-mutator/core": "^9.6.1", | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟠 major — zod 4 stops serialising
issuesin 400 responses, which breaks client error handling that readserrors.issuesIn zod 4,
ZodError.issuesis non-enumerable, sores.json(...)(and zod-express-middleware, whose peer dependency iszod ^3.2.0) no longer includeserrors.issues.packages/app/src/AuthPage.tsx:98depends onjsonData[0].errors.issuesto show per-field registration errors. Several tests assertresponse.body[0].errors.issues, e.g.packages/api/src/routers/api/__tests__/dashboard.int.test.ts:1137.packages/api/src/middleware/validation.ts:12has the same issue. Fix it by replacing zod-express-middleware with a zod-4-aware validator that explicitly sends{ issues: error.issues }.Nothing blocks merge automatically, but a maintainer will expect this fixed if it is a real defect in code this PR changes. If it is about surrounding code, reply and say so instead of patching. Do not widen the PR. How to respond