Repository navigation
refactor: Relocate external API source conversion functions - #3450
Conversation
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🔴 Tier 4 — CriticalTouches authentication, tenancy data models, the public API or shipped database config — or substantially changes the query rendering engine, background tasks, the OTel pipeline, image build, or release CI. Why this tier:
Review process: Deep review from a domain expert. Synchronous walkthrough may be required. Stats
|
PR Review
1 finding(s): 🔴 0 critical · 🟠 0 major · 🔵 1 minor None could be anchored to changed lines; they are listed below. Findings outside the changed lines1 minor
Severity is the reviewer's own estimate and is used for ordering, not filtering. No finding blocks merge automatically; a maintainer decides. |
Duplicate code analysisNo new duplicate code introduced by this PR. jscpd compared this branch against |
[Low impact] The PR appears safe to merge; no actionable behavior changes were found. SummaryMoves external API source conversion helpers into
Reviews (2) · Last reviewed commit: "Merge branch 'main' into drew/move-sourc..." · Reviewed by Greptile |
Deep ReviewScope: 3 files ( The correctness reviewer confirmed the moved functions are byte-identical to the originals; ✅ No critical issues found. 🟡 P2 -- recommended
🔵 P3 nitpicks (3)
Reviewers (5): correctness, testing, maintainability, kieran-typescript, project-standards. Testing gaps: Note: the 2 prior PR comments are automated bot notices (changeset-bot, vercel) with no human review feedback to verify. No finding blocks merge automatically. A maintainer will expect P0/P1 findings in code this PR changes to be fixed; P2/P3 are your call -- fix or reply. Never fix findings about surrounding code here; reply instead. Do not widen the PR. How to respond |
E2E Test Results✅ All tests passed • 458 passed • 1 skipped • 1701s
Tests ran across 4 shards in parallel. |
Summary
This PR moves some external API source conversion functions into common-utils, so that they can be re-used in non-api contexts. This is a pure refactor, no behavior changes are expected.