Repository navigation
fix: point the Connect to Demo Server connection at the new demo ClickHouse - #3419
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Duplicate code analysisNo new duplicate code introduced by this PR. jscpd compared this branch against |
[Medium impact] The PR appears safe to merge; no actionable issues remain. SummaryUpdates “Connect to Demo Server” to use the new ClickHouse host and
Reviews (4) · Last reviewed commit: "Merge branch 'main' into drew/update-dem..." · Reviewed by Greptile |
E2E Test Results✅ All tests passed • 457 passed • 1 skipped • 1525s
Tests ran across 4 shards in parallel. |
8b79d4d to
9c472ab
Compare
🦋 Changeset detectedLatest commit: e2a56f0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
9c472ab to
68d3a89
Compare
🔵 Tier 2 — Low RiskSmall, isolated change with no API route or data model modifications. Why this tier:
Review process: AI review + quick human skim (target: 5–15 min). Reviewer validates AI assessment and checks for domain-specific concerns. Stats
|
PR Review
3 finding(s): 🔴 0 critical · 🟠 1 major · 🔵 2 minor 3 posted as inline comment(s) on the changed lines. Severity is the reviewer's own estimate and is used for ordering, not filtering. No finding blocks merge automatically; a maintainer decides. |
Deep ReviewScope: ✅ No critical issues found. Both prior P1 review comments are resolved in this diff: the test now mocks 🟡 P2 -- recommended
🔵 P3 nitpicks (5)
Reviewers (6): correctness, testing, maintainability, kieran-typescript, julik-frontend-races, previous-comments. Testing gaps: The core migration path (legacy No finding blocks merge automatically. A maintainer will expect P0/P1 findings in code this PR changes to be fixed; P2/P3 are your call -- fix or reply. Never fix findings about surrounding code here; reply instead. Do not widen the PR. How to respond |
|
|
||
| const DEMO_CONNECTION = { | ||
| name: 'Demo', | ||
| host: 'https://b1g1gnrrz3.us-central1.gcp.clickhouse-staging.com:8443', |
There was a problem hiding this comment.
🟠 major — Demo connection is hardcoded to a ClickHouse staging host (*.clickhouse-staging.com:8443)
Before merging, point DEMO_CONNECTION.host at a production or stable public endpoint. Like the old sql-clickhouse.clickhouse.com, it should be a *.clickhouse.com host, not an auto-generated staging instance ID. Every self-hosted install and every Vercel preview will be wired to this host, and the legacy-migration branch rewrites existing Demo connections to it permanently.
Nothing blocks merge automatically, but a maintainer will expect this fixed if it is a real defect in code this PR changes. If it is about surrounding code, reply and say so instead of patching. Do not widen the PR. How to respond
| const mockConnectionsResult = { | ||
| data: [{ id: 'conn-1', name: 'Default', host: 'http://localhost:8123' }], | ||
| }; | ||
| const mockUpdateConnectionMutation = { mutateAsync: jest.fn() }; |
There was a problem hiding this comment.
🔵 minor — New legacy-connection migration path has no test; the mock only exists so the import resolves
Add a test that seeds mockConnectionsResult with {name:'Demo', host:'https://sql-clickhouse.clickhouse.com', username:'otel_demo'}, clicks "Connect to Demo Server", and checks that mockUpdateConnectionMutation.mutateAsync received the new host while create did not run. Add a second case where a Demo connection with a non-legacy host is left alone. Also check that the sources are created with databaseName: 'otel'.
Advisory. Fix if it is a small defect in code this PR changes; otherwise reply in the thread. Do not widen the PR or touch files it did not already change. How to respond
| password: '', | ||
| }; | ||
| const LEGACY_DEMO_CONNECTION = { | ||
| host: 'https://sql-clickhouse.clickhouse.com', |
There was a problem hiding this comment.
🔵 minor — CONTRIBUTING.md still tells contributors to use the old demo host and the otel_v2 database
Update CONTRIBUTING.md lines 124-127 (the manual full-stack demo setup) to the new host and database otel, or reference DEMO_CONNECTION. Contributors who follow it now create a connection that the onboarding code treats as legacy and rewrites.
Advisory. Fix if it is a small defect in code this PR changes; otherwise reply in the thread. Do not widen the PR or touch files it did not already change. How to respond
Summary
This PR updates the demo connection details to point to a new service.
Screenshots or video
Preview environment: https://hyperdx-oss-git-drew-update-demo-connection-hyperdx.vercel.app/search?source=32d9cd5f45baf5d2&where=&select=&whereLanguage=lucene&filters=%255B%255D&orderBy=&from=1792512199482&to=1792513099482
How to reproduce
How to test on Vercel preview
Connect to the demo server in the preview environment, validate in the network tab that the new connection is being hit.
References