Repository navigation
feat: Add group-by to the search page histogram - #3407
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🦋 Changeset detectedLatest commit: 0e48d28 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Duplicate code analysisNo new duplicate code introduced by this PR. jscpd compared this branch against |
[Medium impact] The PR appears safe to merge; no new actionable issues were established. SummaryAdds a histogram group-by picker with Fields and SQL tabs, URL state, and source-switch compatibility checks.
|
E2E Test Results✅ All tests passed • 456 passed • 1 skipped • 1262s
Tests ran across 4 shards in parallel. |
f882d26 to
eac5098
Compare
🟡 Tier 3 — StandardIntroduces new logic, modifies core functionality, or touches areas with non-trivial risk. Why this tier:
Review process: Full human review — logic, architecture, edge cases. Stats
|
PR Review
4 finding(s): 🔴 0 critical · 🟠 0 major · 🔵 4 minor 4 posted as inline comment(s) on the changed lines. Severity is the reviewer's own estimate and is used for ordering, not filtering. No finding blocks merge automatically; a maintainer decides. |
Deep ReviewScope: ✅ No critical issues found. The prior P1 "grouping lowers the result count" is resolved by 🟡 P2 -- recommended
🔵 P3 nitpicks (1)
Reviewers (9): correctness, adversarial, kieran-typescript, frontend-races, performance, testing, maintainability, project-standards, previous-comments. Testing gaps:
No finding blocks merge automatically. A maintainer will expect P0/P1 findings in code this PR changes to be fixed; P2/P3 are your call -- fix or reply. Never fix findings about surrounding code here; reply instead. Do not widen the PR. How to respond |
e50514c to
0082442
Compare
9232fd7 to
0e48d28
Compare
Summary
This PR adds a custom group-by input to the search page histogram.
Screenshots or video
Screen.Recording.2026-10-19.at.6.21.33.PM.mov
How to test on Vercel preview
Visit the search page and try it out!
References