Repository navigation
feat: Filter time chart series into adhoc dashboard filters - #3405
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🦋 Changeset detectedLatest commit: 13cab8d The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
E2E Test Results✅ All tests passed • 446 passed • 1 skipped • 1341s
Tests ran across 4 shards in parallel. |
🔵 Tier 2 — Low RiskSmall, isolated change with no API route or data model modifications. Why this tier:
Review process: AI review + quick human skim (target: 5–15 min). Reviewer validates AI assessment and checks for domain-specific concerns. Stats
|
Duplicate code analysisNo new duplicate code introduced by this PR. jscpd compared this branch against |
PR Review
1 finding(s): 🔴 0 critical · 🟠 0 major · 🔵 1 minor None could be anchored to changed lines; they are listed below. Findings outside the changed lines1 minor
Severity is the reviewer's own estimate and is used for ordering, not filtering. No finding blocks merge automatically; a maintainer decides. |
[Medium impact] The PR appears safe to merge, with no new actionable findings. SummaryAdds Filter and Exclude actions to pinned time-chart tooltips.
pulpdrew accepted the risk that labels created by PromQL expressions may not match the input metrics, citing Grafana-compatible behavior and easy filter removal. The earlier file-size thread was manually resolved without explanation. Both previous threads were unnumbered, so neither has a numbered previous-finding entry.
|
Deep Review✅ No critical issues found. No P0/P1 defects: the filter-value path is injection-safe (values are escaped via 🟡 P2 — recommended
🔵 P3 nitpicks (4)
Reviewers (8): correctness, adversarial, kieran-typescript, julik-frontend-races, testing, maintainability, project-standards, previous-comments. Testing gaps:
Note: The No finding blocks merge automatically. A maintainer will expect P0/P1 findings in code this PR changes to be fixed; P2/P3 are your call -- fix or reply. Never fix findings about surrounding code here; reply instead. Do not widen the PR. How to respond |
54aa4d0 to
2e81d13
Compare
2e81d13 to
54c9abf
Compare
54c9abf to
13cab8d
Compare

Summary
This PR adds click-to-adhoc-filter functionality to timecharts (line, stacked bar, stacked line) via the series tooltip. The tooltip gains a new action button that adds all of a series' labels to the relevant adhoc filter.
Like #3389, the "filter keys" (expressions being filtered) are intended to be any group-by keys.
This determination is made as follows:
Exclude is offered only for series with a single key, because ANDed != conditions can't exclude one combination of values.
Screenshots or video
Screen.Recording.2026-10-20.at.9.38.35.AM.mov
How to test on Vercel preview
Create a dashboard, add some line charts and an adhoc filter on the same source, click some series tooltips to update the filter.
References