Repository navigation
fix(mcp): default whereLanguage to lucene when creating a saved search #3404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
25ad7ee
063d287
0c0ed30
121e998
198947c
2ba7990
7635679
22c59b1
12d4720
22deef6
17d1449
cbca7c2
36f4c53
9400561
4ffb744
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| '@hyperdx/api': patch | ||
| --- | ||
|
|
||
| fix(mcp): store whereLanguage as lucene when clickstack_save_saved_search creates a search without one, so its alerts no longer parse a Lucene filter as SQL |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -60,7 +60,9 @@ export function registerSaveSavedSearch({ | |
| name: input.name, | ||
| select: input.select ?? '', | ||
| where: input.where ?? '', | ||
| whereLanguage: input.whereLanguage, | ||
| // Alerts read a missing whereLanguage as sql while the app reads it as | ||
| // lucene, so a new search must store it explicitly. | ||
| whereLanguage: input.whereLanguage ?? (isUpdate ? undefined : 'lucene'), | ||
|
brandon-pereira marked this conversation as resolved.
Resolved
brandon-pereira marked this conversation as resolved.
Resolved
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🟠 major — Saved searches already stored without whereLanguage keep running their alerts as SQL This change only fixes searches created from now on. Searches that Nothing blocks merge automatically, but a maintainer will expect this fixed if it is a real defect in code this PR changes. If it is about surrounding code, reply and say so instead of patching. Do not widen the PR. How to respond |
||
| orderBy: input.orderBy, | ||
| source: input.sourceId, | ||
| tags: input.tags ?? [], | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.