Skip to content

refactor: switch out mantine badges for click-ui badges in tags and experimental sections - #3398

Merged
hoorayimhelping merged 5 commits into
mainfrom
bucky-click-ui-mantine-badges-tags-experimental
Oct 19, 2026
Merged

hoorayimhelping merged 5 commits into
mainfrom
bucky-click-ui-mantine-badges-tags-experimental

Conversation

@hoorayimhelping

Copy link
Copy Markdown
Member

Summary

  • Switch out more mantine badges with click-ui badges.
    • Tags and experimental sections

Screenshots or video

01-dashboard-card-tags 02-dashboard-row-tags 03-alert-card-tags 04-alert-terraform-modal 05-alert-detail-tags 06-team-sources-disabled 07-team-members 08-team-iac-experimental 09-user-preferences 10-service-map-beta 11-dev-only

How to test on Vercel preview

  1. Dashboards: the tags on the cards, in grid and list view.
  2. Alerts: the tags on an alert card and on its detail page.
  3. Team Settings → Members: the "You" badge, and the "Pending invite" badge after you invite someone.
  4. User Preferences: the "Experimental" badge and the "Dev only" badge.
  5. Search → open a trace → Service Map tab: the "Beta" badge.

@changeset-bot

changeset-bot Bot commented Oct 16, 2026 •

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 3e965d9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@hyperdx/app Patch
@hyperdx/api Patch
@hyperdx/otel-collector Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercel Bot commented Oct 16, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
hyperdx-oss Ready Ready Preview Oct 19, 2026 3:11pm UTC
hyperdx-storybook Ready Ready Preview Oct 19, 2026 3:11pm UTC

Request Review

@github-actions github-actions Bot added the review/tier-2 Low risk — AI review + quick human skim label Oct 16, 2026
@github-actions

Copy link
Copy Markdown
Contributor

🔵 Tier 2 — Low Risk

Small, isolated change with no API route or data model modifications.

Why this tier:

  • Standard feature/fix — introduces new logic or modifies core functionality

Review process: AI review + quick human skim (target: 5–15 min). Reviewer validates AI assessment and checks for domain-specific concerns.
SLA: Resolve within 4 business hours.

Stats
  • Production files changed: 10
  • Production lines changed: 128 (+ 2 in test files, excluded from tier calculation)
  • Branch: bucky-click-ui-mantine-badges-tags-experimental
  • Author: hoorayimhelping

To override this classification, remove the review/tier-2 label and apply a different review/tier-* label. Manual overrides are preserved on subsequent pushes.

@github-actions

Copy link
Copy Markdown
Contributor

Duplicate code analysis

No new duplicate code introduced by this PR.


jscpd compared this branch against origin/main
across app, api and common-utils. Only new clones are listed; the codebase
currently holds 125 in total (1.69%).
Run yarn dupes locally to reproduce, or yarn dupes:all for the full picture.

@@ -188,14 +185,12 @@ export const UserPreferencesModal = ({
w={220}
>
<Badge

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 minor — Mantine Tooltip now wraps a click-ui Badge, and the Tooltip may not be able to attach a ref to it

Mantine Tooltip clones its child and attaches a ref so floating-ui can position the tooltip. Unless click-ui's Badge forwards refs, the 'Only available in local/dev mode…' tooltip will be mispositioned or won't show. I couldn't check the click-ui source (node_modules isn't in this checkout), so confirm whether Badge forwards refs. If it doesn't, wrap it in an element that takes a ref, e.g. <Tooltip …><span><Badge … /></span></Tooltip>, and check the tooltip still appears on hover.

Advisory. Fix if it is a small defect in code this PR changes; otherwise reply in the thread. Do not widen the PR or touch files it did not already change. How to respond

size="sm"
text="Beta"
state="info"
style={{ marginInlineStart: 'var(--mantine-spacing-xs)' }}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 minor — Raw inline margin style where the parent Group's gap would do the same job

The repo conventions say to prefer Mantine style props over raw style objects. Remove style={{ marginInlineStart: 'var(--mantine-spacing-xs)' }} from the Badge, change the parent <Group gap={0}> to <Group gap="xs">, and the spacing stays the same. TeamMembersSection.tsx:264 has the same pattern: put the 'You' badge and the name in a <Group gap="xs"> instead of setting an inline marginRight.

Advisory. Fix if it is a small defect in code this PR changes; otherwise reply in the thread. Do not widen the PR or touch files it did not already change. How to respond

@github-actions

github-actions Bot commented Oct 16, 2026 •

Copy link
Copy Markdown
Contributor

PR Review

If you are a coding agent acting for the author, read this first.
Nothing below blocks merge automatically; a maintainer decides. What they will expect:

  • 🔴 critical or 🟠 major in code this PR adds or changes: fix before asking for review.
  • 🔵 minor in code this PR changes: your call. Fix if small, otherwise reply.
  • Anything about surrounding code, or asking you to widen the change (hoist a helper,
    dedupe with another file, fix other call sites): never fix here, whatever the
    severity. Reply with one sentence; if it is critical, say so plainly so a human sees it.

One commit per review round. After two rounds, stop and ask a maintainer to review
scope rather than addressing more automated findings. Full rule: AGENTS.md.

2 finding(s): 🔴 0 critical · 🟠 0 major · 🔵 2 minor

2 posted as inline comment(s) on the changed lines.


Severity is the reviewer's own estimate and is used for ordering, not filtering. No finding blocks merge automatically; a maintainer decides.

@greptile-apps

greptile-apps Bot commented Oct 16, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The PR appears safe to merge; no actionable issues were found.

Summary

Replaces Mantine badges with Click UI badges for tags and status labels.

  • Dashboard and alert tags use Click UI badges.
  • Experimental and Beta labels use Click UI badges.
  • Development-only and disabled labels use Click UI badges.
  • Team member labels use Click UI badges.

Reviews (5) · Last reviewed commit: "Merge branch 'main' into bucky-click-ui-..." · Reviewed by Greptile

@github-actions

github-actions Bot commented Oct 16, 2026 •

Copy link
Copy Markdown
Contributor

Deep Review

A contained presentational refactor: Mantine Badge swapped for the click-ui Badge across 10 components plus one e2e string update. Behavior is unchanged; the swap uses props (size/text/state/style) already proven in committed usages elsewhere. No logic, data, or auth surface is touched.

✅ No critical issues found.

🟡 P2 — recommended

  • packages/app/src/UserPreferencesModal.tsx:214 — the new icon="flask"/iconDir="start" Badge props (and icon="dot" at packages/app/src/components/TeamSettings/TeamMembersSection.tsx:312) are introduced here, appear nowhere else in the repo, are exercised by no test, and the click-ui BadgeProps icon-name/iconDir contract could not be verified in this environment (package not installed, network blocked).
    • Fix: Verify icon="flask", icon="dot", and iconDir="start" against @clickhouse/click-ui@0.12.0 BadgeProps with dependencies installed, and add a render assertion so a silently-dropped or invalid icon is caught.
    • correctness, kieran-typescript, testing
🔵 P3 nitpicks (2)
  • packages/app/src/components/ServiceMap/ServiceMapSidePanel.tsx:30 — the "Beta" badge moved from gray to state="info" (blue) while the sibling "Disabled" badge at packages/app/src/components/Sources/SourcesList.tsx:209 stayed state="neutral", so two formerly-identical gray chips now diverge.

    • Fix: Set the "Beta" badge to state="neutral" if the color change was incidental rather than intended.
  • packages/app/src/components/ServiceMap/ServiceMapSidePanel.tsx:32 — badge spacing was reimplemented as a raw inline style referencing var(--mantine-spacing-xs), using marginInlineStart here and marginRight at packages/app/src/components/TeamSettings/TeamMembersSection.tsx:251 for the same "gap after badge" intent, coupling a click-ui component to a Mantine CSS variable.

    • Fix: Express the spacing once via a Mantine Group/Box wrapper (or a shared badge wrapper) instead of two divergent inline styles.

Reviewers (4): correctness, maintainability, testing, kieran-typescript.

Testing gaps:

  • No unit assertion covers the swapped "Experimental", "Beta", "Disabled", or "Dev only" badges; only "You" and "Pending invite" are exercised (team e2e).
  • The new icon-bearing badges have no test confirming the icon actually renders, so an invalid/ignored icon name would go undetected.

No finding blocks merge automatically. A maintainer will expect P0/P1 findings in code this PR changes to be fixed; P2/P3 are your call -- fix or reply. Never fix findings about surrounding code here; reply instead. Do not widen the PR. How to respond

@github-actions

github-actions Bot commented Oct 16, 2026 •

Copy link
Copy Markdown
Contributor

E2E Test Results

✅ All tests passed • 435 passed • 1 skipped • 1651s

Status Count
✅ Passed 435
❌ Failed 0
⚠️ Flaky 3
⏭️ Skipped 1

Tests ran across 4 shards in parallel.

View full report →

size="sm"
text="Beta"
state="info"
style={{ marginInlineStart: 'var(--mantine-spacing-xs)' }}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 minor — The Beta badge's spacing is set with a raw style using a Mantine CSS variable, when the parent Group could provide the gap

Change the parent to <Group gap="xs"> (it is currently gap={0}) and remove the style={{ marginInlineStart: 'var(--mantine-spacing-xs)' }} from the Badge. This follows the convention to prefer Mantine style props over raw styles. Other click-ui badges get their spacing from a Group gap, for example in IacMigrationSection.tsx and LLMDashboardPage.tsx.

Advisory. Fix if it is a small defect in code this PR changes; otherwise reply in the thread. Do not widen the PR or touch files it did not already change. How to respond

size="sm"
text="You"
state="info"
style={{

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 minor — The 'You' badge's spacing is set with a hand-written marginRight: var(--mantine-spacing-xs) style

Replace the wrapping <div> with <Group gap="xs"> (or a Box with style props) and remove the inline style on the Badge. This follows the convention to prefer Mantine style props over raw styles, and it stops the badge from depending on Mantine's internal spacing variable.

Advisory. Fix if it is a small defect in code this PR changes; otherwise reply in the thread. Do not widen the PR or touch files it did not already change. How to respond

@hoorayimhelping
hoorayimhelping merged commit d3e6f96 into main Oct 19, 2026
42 of 44 checks passed

This branch was successfully deployed

2 active deployments
Preview – hyperdx-oss — 3e965d9f Deployed Oct 19, 2026 by vercel[bot]
Preview – hyperdx-storybook — 3e965d9f Deployed Oct 19, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

review/tier-2 Low risk — AI review + quick human skim

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants