Repository navigation
refactor: switch out mantine badges for click-ui badges in tags and experimental sections - #3398
Conversation
…xperimental sections
🦋 Changeset detectedLatest commit: 3e965d9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🔵 Tier 2 — Low RiskSmall, isolated change with no API route or data model modifications. Why this tier:
Review process: AI review + quick human skim (target: 5–15 min). Reviewer validates AI assessment and checks for domain-specific concerns. Stats
|
Duplicate code analysisNo new duplicate code introduced by this PR. jscpd compared this branch against |
| @@ -188,14 +185,12 @@ export const UserPreferencesModal = ({ | |||
| w={220} | |||
| > | |||
| <Badge | |||
There was a problem hiding this comment.
🔵 minor — Mantine Tooltip now wraps a click-ui Badge, and the Tooltip may not be able to attach a ref to it
Mantine Tooltip clones its child and attaches a ref so floating-ui can position the tooltip. Unless click-ui's Badge forwards refs, the 'Only available in local/dev mode…' tooltip will be mispositioned or won't show. I couldn't check the click-ui source (node_modules isn't in this checkout), so confirm whether Badge forwards refs. If it doesn't, wrap it in an element that takes a ref, e.g. <Tooltip …><span><Badge … /></span></Tooltip>, and check the tooltip still appears on hover.
Advisory. Fix if it is a small defect in code this PR changes; otherwise reply in the thread. Do not widen the PR or touch files it did not already change. How to respond
| size="sm" | ||
| text="Beta" | ||
| state="info" | ||
| style={{ marginInlineStart: 'var(--mantine-spacing-xs)' }} |
There was a problem hiding this comment.
🔵 minor — Raw inline margin style where the parent Group's gap would do the same job
The repo conventions say to prefer Mantine style props over raw style objects. Remove style={{ marginInlineStart: 'var(--mantine-spacing-xs)' }} from the Badge, change the parent <Group gap={0}> to <Group gap="xs">, and the spacing stays the same. TeamMembersSection.tsx:264 has the same pattern: put the 'You' badge and the name in a <Group gap="xs"> instead of setting an inline marginRight.
Advisory. Fix if it is a small defect in code this PR changes; otherwise reply in the thread. Do not widen the PR or touch files it did not already change. How to respond
PR Review
2 finding(s): 🔴 0 critical · 🟠 0 major · 🔵 2 minor 2 posted as inline comment(s) on the changed lines. Severity is the reviewer's own estimate and is used for ordering, not filtering. No finding blocks merge automatically; a maintainer decides. |
[Medium impact] The PR appears safe to merge; no actionable issues were found. SummaryReplaces Mantine badges with Click UI badges for tags and status labels.
Reviews (5) · Last reviewed commit: "Merge branch 'main' into bucky-click-ui-..." · Reviewed by Greptile |
Deep ReviewA contained presentational refactor: Mantine ✅ No critical issues found. 🟡 P2 — recommended
🔵 P3 nitpicks (2)
Reviewers (4): correctness, maintainability, testing, kieran-typescript. Testing gaps:
No finding blocks merge automatically. A maintainer will expect P0/P1 findings in code this PR changes to be fixed; P2/P3 are your call -- fix or reply. Never fix findings about surrounding code here; reply instead. Do not widen the PR. How to respond |
E2E Test Results✅ All tests passed • 435 passed • 1 skipped • 1651s
Tests ran across 4 shards in parallel. |
| size="sm" | ||
| text="Beta" | ||
| state="info" | ||
| style={{ marginInlineStart: 'var(--mantine-spacing-xs)' }} |
There was a problem hiding this comment.
🔵 minor — The Beta badge's spacing is set with a raw style using a Mantine CSS variable, when the parent Group could provide the gap
Change the parent to <Group gap="xs"> (it is currently gap={0}) and remove the style={{ marginInlineStart: 'var(--mantine-spacing-xs)' }} from the Badge. This follows the convention to prefer Mantine style props over raw styles. Other click-ui badges get their spacing from a Group gap, for example in IacMigrationSection.tsx and LLMDashboardPage.tsx.
Advisory. Fix if it is a small defect in code this PR changes; otherwise reply in the thread. Do not widen the PR or touch files it did not already change. How to respond
| size="sm" | ||
| text="You" | ||
| state="info" | ||
| style={{ |
There was a problem hiding this comment.
🔵 minor — The 'You' badge's spacing is set with a hand-written marginRight: var(--mantine-spacing-xs) style
Replace the wrapping <div> with <Group gap="xs"> (or a Box with style props) and remove the inline style on the Badge. This follows the convention to prefer Mantine style props over raw styles, and it stops the badge from depending on Mantine's internal spacing variable.
Advisory. Fix if it is a small defect in code this PR changes; otherwise reply in the thread. Do not widen the PR or touch files it did not already change. How to respond
Summary
Screenshots or video
How to test on Vercel preview