Repository navigation
feat: fetch key limit now applies per map - #3392
Conversation
🦋 Changeset detectedLatest commit: e2a57ba The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Duplicate code analysisNo new duplicate code introduced by this PR. jscpd compared this branch against |
PR Review
2 finding(s): 🔴 0 critical · 🟠 1 major · 🔵 1 minor None could be anchored to changed lines; they are listed below. Findings outside the changed lines
1 minor
Severity is the reviewer's own estimate and is used for ordering, not filtering. No finding blocks merge automatically; a maintainer decides. |
🔵 Tier 2 — Low RiskSmall, isolated change with no API route or data model modifications. Why this tier:
Review process: AI review + quick human skim (target: 5–15 min). Reviewer validates AI assessment and checks for domain-specific concerns. Stats
|
[Medium impact] The PR appears safe to merge, with a non-blocking sidebar loading and ordering issue.
|
Deep ReviewScope: 3 files ( ✅ No critical issues found. Correctness review verified key/condition alignment, the 🟡 P2 — recommended
🔵 P3 nitpicks (3)
Reviewers (6): correctness, testing, maintainability, kieran-typescript, performance, previous-comments. Testing gaps:
No finding blocks merge automatically. A maintainer will expect P0/P1 findings in code this PR changes to be fixed; P2/P3 are your call -- fix or reply. Never fix findings about surrounding code here; reply instead. Do not widen the PR. How to respond |
E2E Test Results✅ All tests passed • 436 passed • 1 skipped • 1546s
Tests ran across 4 shards in parallel. |
7625bb7 to
c934292
Compare
c934292 to
86aa449
Compare
| databaseName: chartConfig.from.databaseName, | ||
| tableName: chartConfig.from.tableName, | ||
| keyExpressions: keys.slice(0, maxKeys), | ||
| keyExpressions: limitedKeys, |
There was a problem hiding this comment.
The hook now fetches keys beyond the first global maxKeys, but the sidebar still passes escapedKeysToFetch.slice(0, maxKeys) to listRequestedFacets. With 100 LogAttributes keys followed by ResourceAttributes, the resource filters get no loading rows. They appear only when their values arrive, and later maps follow completion order rather than request order.
Use the same per-map selection for the sidebar's requested-key list so these filters stay visible and keep their order while loading.
Summary
The fetch key limit now applies per map. Previously, the behavior was a bit random. If you find 100 LogAttributes, often times the ResourceAttributes wouldn't display in the filters at all, and values would not be fetched for any ResourceAttribute columns. Now, for a fetch key limit of n, there will be n keys attempting to fetch values instead of 100 total across all maps.
References