Skip to content

fix: wrap long values in release marker tooltips - #3391

Merged
kodiakhq[bot] merged 5 commits into
mainfrom
cursor/wrap-release-marker-tooltip-text-df62
Oct 16, 2026
Merged

kodiakhq[bot] merged 5 commits into
mainfrom
cursor/wrap-release-marker-tooltip-text-df62

Conversation

@MikeShi42

@MikeShi42 MikeShi42 commented Oct 16, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Release marker tooltip rows forced white-space: nowrap on both the service name and the version. The tooltip is a fixed 280px wide and is pointer-events: none, so any value wider than that overflowed horizontally into a scrollbar the pointer could never reach — the text was simply unreadable. This shows up as soon as a source's version expression concatenates attributes beyond ResourceAttributes['service.version'], which is the documented workaround for surfacing extra release metadata.

Three changes, all scoped to the release marker tooltip:

  • Rows wrap instead of overflowing. overflow-wrap: anywhere rather than break-word because only anywhere shrinks an element's min-content width, which is what the wrap="nowrap" flex row measures — with break-word the row would still be sized by its longest unbroken token and still overflow. The marker dot top-aligns (with a small offset to sit on the first line) now that a row can be several lines tall.
  • The service name has an 80px floor. Both values share the row's width, so a long version otherwise wraps the service name down to two or three characters per line (see "search-indexer" in the before shot) — and the service name is the thing the tooltip exists to say.
  • The release list gets a 500px height cap instead of the shared 200px. Wrapped values are several lines tall each, so a cluster of releases hit the shared cap almost immediately and the rest was clipped behind another unreachable scrollbar. A new annotationTooltipContent class rather than raising chartTooltipContent, which the series tooltips also use.

Short values render as before, except that the 80px floor now lines the version column up across rows.

Screenshots or video

Five releases in one hovered cluster, two of them with a concatenated version value.

Before After
Tooltip on main: every row is clipped at the right edge, so no version is readable at all Tooltip on this branch: service names and versions wrap into two aligned columns and every row is fully visible

How to reproduce

Starting point: yarn dev (the change needs a source whose Service Version Expression is edited in Team Settings).

On main:

  1. In Team settings, set the source's "Service Version Expression" to something that concatenates attributes, e.g. concat(ResourceAttributes['service.version'], ' — ', ResourceAttributes['k8s.cluster.name'], ' — ', ResourceAttributes['deployment.environment']).
  2. Open a dashboard tile on that source and turn on release markers.
  3. Hover a release marker. The tooltip text runs past the right edge; a horizontal scrollbar appears but can't be grabbed because the tooltip ignores pointer events. Widening the tile or changing the time range doesn't help.

On this branch:

  1. Same steps. The service name and version wrap onto multiple lines inside the tooltip and the full value is readable. Hover a marker that collapses several releases ("N releases") to see the taller list.

How to test on Vercel preview

N/A — reaching the tooltip requires editing a source's version expression in Team settings, which isn't available in LOCAL_MODE.

References

  • Linear Issue: HDX-5740

Linear Issue: HDX-5740

Open in Web Open in Cursor 

cursoragent and others added 2 commits October 16, 2026 16:42
Co-authored-by: Mike Shi <mike@hyperdx.io>
Co-authored-by: Mike Shi <mike@hyperdx.io>
@changeset-bot

changeset-bot Bot commented Oct 16, 2026 •

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: bae04f3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@hyperdx/app Patch
@hyperdx/api Patch
@hyperdx/otel-collector Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercel Bot commented Oct 16, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
hyperdx-oss Ready Ready Preview Oct 16, 2026 6:09pm UTC
hyperdx-storybook Ready Ready Preview Oct 16, 2026 6:09pm UTC

Request Review

@github-actions

github-actions Bot commented Oct 16, 2026 •

Copy link
Copy Markdown
Contributor

Duplicate code analysis

No new duplicate code introduced by this PR.


jscpd compared this branch against origin/main
across app, api and common-utils. Only new clones are listed; the codebase
currently holds 125 in total (1.69%).
Run yarn dupes locally to reproduce, or yarn dupes:all for the full picture.

@greptile-apps

greptile-apps Bot commented Oct 16, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Low impact] The PR appears safe to merge, with the earlier non-blocking concern about hidden releases only partly addressed.

Fix All in Claude CodeFindings

  1. P2 Lower releases become unreadable ▶

Summary

Release marker tooltips now wrap long service names and versions.

  • Release marker tooltips wrap long names and versions inside the tooltip.

Reviews (4) · Last reviewed commit: "Merge branch 'main' into cursor/wrap-rel..." · Reviewed by Greptile

Comment on lines +80 to +84
<Text size="xs" c="dimmed" style={wrapLongValue}>
{member.group}
</Text>
)}
<Text size="xs" fw={500} style={{ whiteSpace: 'nowrap' }}>
<Text size="xs" fw={500} style={wrapLongValue}>

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Lower releases become unreadable

Wrapping makes clustered release rows taller, but ChartTooltipContainer still caps its content at 200px. A cluster that previously fit can now hide its lower releases behind a vertical scrollbar. Since AnnotationTooltip sets pointerEvents: 'none', users cannot scroll to them. Provide a reachable scroll or pinned view for wrapped content that exceeds the cap.

Fix in Claude Code Fix in Conductor Fix in Cursor Fix in Codex

@github-actions

github-actions Bot commented Oct 16, 2026 •

Copy link
Copy Markdown
Contributor

E2E Test Results

✅ All tests passed • 431 passed • 1 skipped • 1815s

Status Count
✅ Passed 431
❌ Failed 0
⚠️ Flaky 0
⏭️ Skipped 1

Tests ran across 4 shards in parallel.

View full report →

…t cap

Co-authored-by: Mike Shi <mike@hyperdx.io>
@github-actions

Copy link
Copy Markdown
Contributor

🔵 Tier 2 — Low Risk

Small, isolated change with no API route or data model modifications.

Why this tier:

  • Standard feature/fix — introduces new logic or modifies core functionality

Review process: AI review + quick human skim (target: 5–15 min). Reviewer validates AI assessment and checks for domain-specific concerns.
SLA: Resolve within 4 business hours.

Stats
  • Production files changed: 2
  • Production lines changed: 38 (+ 51 in test files, excluded from tier calculation)
  • Branch: cursor/wrap-release-marker-tooltip-text-df62
  • Author: MikeShi42

To override this classification, remove the review/tier-2 label and apply a different review/tier-* label. Manual overrides are preserved on subsequent pushes.


// Release-marker tooltip only. Its values wrap over several lines each, so the
// shared cap above clips a cluster of releases almost immediately.
.annotationTooltipContent {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟠 major — Releases past 500px still sit behind a scrollbar nobody can reach

.annotationTooltipContent raises the height cap but keeps the overflow-y: auto it inherits from .chartTooltipContent. The tooltip is pointer-events: none (AnnotationTooltip.tsx:62), and members has no upper bound (chartAnnotations.tsx:222 slices the whole cluster). So a big cluster of wrapped rows still overflows into a scrollbar that can't be used, which is the same problem this PR fixes for width. Do what .chartTooltipContentClipped already does (overflow: hidden), and cap the rendered rows with a "+N more" line so the cut is visible.

Nothing blocks merge automatically, but a maintainer will expect this fixed if it is a real defect in code this PR changes. If it is about surrounding code, reply and say so instead of patching. Do not widen the PR. How to respond

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Separate fix - and it would be annoying.

// Release-marker tooltip only. Its values wrap over several lines each, so the
// shared cap above clips a cluster of releases almost immediately.
.annotationTooltipContent {
max-height: 500px;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 minor — Fixed 500px cap ignores viewport height for a tooltip that never flips

The tooltip is position: fixed and always opens downward from the marker (top: point.y + 6), with no flip or clamp. A 500px list plus the header runs off the bottom of the screen for tiles in the lower part of a dashboard or on short viewports. Before, the 200px cap mostly hid this. Bound it to the viewport the way the series list at line 51 does, e.g. max-height: min(500px, 40vh).

Advisory. Fix if it is a small defect in code this PR changes; otherwise reply in the thread. Do not widen the PR or touch files it did not already change. How to respond

@github-actions

github-actions Bot commented Oct 16, 2026 •

Copy link
Copy Markdown
Contributor

PR Review

If you are a coding agent acting for the author, read this first.
Nothing below blocks merge automatically; a maintainer decides. What they will expect:

  • 🔴 critical or 🟠 major in code this PR adds or changes: fix before asking for review.
  • 🔵 minor in code this PR changes: your call. Fix if small, otherwise reply.
  • Anything about surrounding code, or asking you to widen the change (hoist a helper,
    dedupe with another file, fix other call sites): never fix here, whatever the
    severity. Reply with one sentence; if it is critical, say so plainly so a human sees it.

One commit per review round. After two rounds, stop and ask a maintainer to review
scope rather than addressing more automated findings. Full rule: AGENTS.md.

3 finding(s): 🔴 0 critical · 🟠 0 major · 🔵 3 minor

3 posted as inline comment(s) on the changed lines.


Severity is the reviewer's own estimate and is used for ordering, not filtering. No finding blocks merge automatically; a maintainer decides.

@github-actions

github-actions Bot commented Oct 16, 2026 •

Copy link
Copy Markdown
Contributor

Deep Review

A small, well-scoped frontend change: release-marker tooltip rows now wrap long service names and versions instead of overflowing a fixed-width, pointer-events: none tooltip. The change is CSS-only behavior plus a new test file and a changeset. No P0/P1 issues found; the one substantive concern is a pre-existing overflow limitation that this diff mitigates rather than introduces.

✅ No critical issues found.

🟡 P2 -- recommended

  • packages/app/styles/HDXLineChart.module.scss:97 -- .annotationTooltipContent raises the height cap to 500px but inherits overflow-y: auto from .chartTooltipContent, so a release cluster taller than 500px still renders a vertical scrollbar that cannot be reached because the tooltip is pointer-events: none.
    • Fix: set overflow-y: hidden on .annotationTooltipContent to mirror the horizontal .chartTooltipContentClipped pattern, or track the reachable-scroll fix as an explicit follow-up.
    • correctness-reviewer — pre-existing (the base 200px cap had the same flaw) and mitigated by this diff; the existing PR thread already flags it and the author deferred it to separate work, so this is a recommended follow-up, not a blocker.
🔵 P3 nitpicks (2)
  • packages/app/src/components/charts/AnnotationTooltip.tsx:85 -- the dot's marginTop: 5 is a magic offset tuned to center an 8px dot on the first line of size="xs" text, and will drift above the baseline once the recently-added configurable --hdx-content-font-size-compact enlarges the line.
    • Fix: derive the offset from the line-height or use an em-relative value so the dot tracks font-size changes.
  • packages/app/src/components/charts/__tests__/AnnotationTooltip.test.tsx:43 -- the test asserts only that the class annotationTooltipContent is present, not the effective 500px cap, so reordering .annotationTooltipContent above .chartTooltipContent (equal single-class specificity) would silently revert the cap to 200px without failing any test.
    • Fix: assert the computed max-height, or add a comment pinning the required source order in the SCSS.

Reviewers (6 dispatched): correctness, testing, maintainability, project-standards, kieran-typescript, previous-comments. Findings synthesized from the correctness reviewer plus orchestrator-level verification; the remaining reviewers were dispatched and their likely scope (CSS-module test behavior, changeset convention, inline-style/type correctness, prior-comment disposition) was independently checked.

Independently verified (no finding): CSS modules map to identity-obj-proxy (packages/app/jest.config.js:22), so the test's .closest('.chartTooltipContent') / .toHaveClass('annotationTooltipContent') assertions resolve correctly and are not broken. The changeset format ('@hyperdx/app': patch) matches repo convention. The as const on wrapLongValue is required for the OverflowWrap type and is correct.

Testing gaps:

  • No assertion of the effective 500px cap (only class presence), so a SCSS source-order change would regress the height silently.
  • No coverage for the multi-member cluster path (members array) or the group == null row; these are unchanged behaviors but now sit adjacent to the wrapped layout.

No finding blocks merge automatically. A maintainer will expect P0/P1 findings in code this PR changes to be fixed; P2/P3 are your call -- fix or reply. Never fix findings about surrounding code here; reply instead. Do not widen the PR. How to respond


// Release-marker tooltip only. Its values wrap over several lines each, so the
// shared cap above clips a cluster of releases almost immediately.
.annotationTooltipContent {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 minor — Release tooltip still gets a scrollbar the pointer can't reach once content passes 500px

.annotationTooltipContent only raises max-height. It still inherits overflow-y: auto from .chartTooltipContent, and the portal wrapper in AnnotationTooltip.tsx sets pointerEvents: 'none'. So when a large release cluster with wrapped values grows past 500px, it gets the same unreachable scrollbar this PR is trying to remove. Add overflow: hidden to match the hover-only .chartTooltipContentClipped rule a few lines above, or reuse that pattern.

Advisory. Fix if it is a small defect in code this PR changes; otherwise reply in the thread. Do not widen the PR or touch files it did not already change. How to respond

// Release-marker tooltip only. Its values wrap over several lines each, so the
// shared cap above clips a cluster of releases almost immediately.
.annotationTooltipContent {
max-height: 500px;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 minor — 500px tooltip opens below the marker with no viewport clamp

AnnotationHitLayer.tsx anchors the tooltip at the bottom of the label band, which is the top of the chart, and AnnotationTooltip sets top = point.y + 6 with no flip or clamp. For a chart in the lower half of the screen, a tooltip that can now be 500px tall plus its header runs off the bottom of the viewport, and the user can't scroll it. Cap the height relative to the viewport, e.g. max-height: min(500px, calc(100vh - <anchor>)) passed as an inline style, or flip the tooltip above the marker when there isn't room below.

Advisory. Fix if it is a small defect in code this PR changes; otherwise reply in the thread. Do not widen the PR or touch files it did not already change. How to respond

<Text
size="xs"
c="dimmed"
style={{ ...wrapLongValue, minWidth: SERVICE_MIN_WIDTH_PX }}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 minor — minWidth set via raw style instead of a Mantine style prop

The Repository conventions say to prefer individual Mantine style props over raw styles. Use miw={SERVICE_MIN_WIDTH_PX} on the Text and keep only overflowWrap in style, since Mantine has no style prop for it.

Advisory. Fix if it is a small defect in code this PR changes; otherwise reply in the thread. Do not widen the PR or touch files it did not already change. How to respond

@kodiakhq
kodiakhq Bot merged commit 685f465 into main Oct 16, 2026
29 checks passed
@kodiakhq
kodiakhq Bot deleted the cursor/wrap-release-marker-tooltip-text-df62 branch October 16, 2026 18:15

This branch was successfully deployed

2 active deployments
Preview – hyperdx-oss — bae04f32 Deployed Oct 16, 2026 by vercel[bot]
Preview – hyperdx-storybook — bae04f32 Deployed Oct 16, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automerge review/tier-2 Low risk — AI review + quick human skim

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants