Skip to content

refactor: update AppNav to use click-ui badges - #3378

Merged
hoorayimhelping merged 3 commits into
mainfrom
bucky-clickui-badges-appnav
Oct 16, 2026
Merged

hoorayimhelping merged 3 commits into
mainfrom
bucky-clickui-badges-appnav

Conversation

@hoorayimhelping

Copy link
Copy Markdown
Member

Summary

  • This changes AppNav to replace the existing mantine badges with click-ui badges

Screenshots or video

Before After
1-sidebar-utc-beta 1-sidebar-utc-beta
2-sidebar-instance-label 2-sidebar-instance-label
3-help-menu-whats-new 3-help-menu-whats-new
4-whats-new-drawer 4-whats-new-drawer

How to reproduce

  1. Open the app
  2. Check the Service Map badge
  3. Click Help on nav; check the badges on changes.
  4. Click View all releases ->; check the badges on that flyout

@vercel

vercel Bot commented Oct 15, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
hyperdx-oss Ready Ready Preview Oct 16, 2026 12:34pm UTC
hyperdx-storybook Ready Ready Preview Oct 16, 2026 12:34pm UTC

Request Review

@changeset-bot

changeset-bot Bot commented Oct 15, 2026 •

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 03807cd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@hyperdx/app Patch
@hyperdx/api Patch
@hyperdx/otel-collector Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions Bot added the review/tier-2 Low risk — AI review + quick human skim label Oct 15, 2026
@github-actions

Copy link
Copy Markdown
Contributor

🔵 Tier 2 — Low Risk

Small, isolated change with no API route or data model modifications.

Why this tier:

  • Standard feature/fix — introduces new logic or modifies core functionality

Review process: AI review + quick human skim (target: 5–15 min). Reviewer validates AI assessment and checks for domain-specific concerns.
SLA: Resolve within 4 business hours.

Stats
  • Production files changed: 5
  • Production lines changed: 58 (+ 37 in test files, excluded from tier calculation)
  • Branch: bucky-clickui-badges-appnav
  • Author: hoorayimhelping

To override this classification, remove the review/tier-2 label and apply a different review/tier-* label. Manual overrides are preserved on subsequent pushes.

@github-actions

github-actions Bot commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor

Duplicate code analysis

No new duplicate code introduced by this PR.


jscpd compared this branch against origin/main
across app, api and common-utils. Only new clones are listed; the codebase
currently holds 125 in total (1.70%).
Run yarn dupes locally to reproduce, or yarn dupes:all for the full picture.

@@ -1,4 +1,5 @@
import { Badge, Box, Group, Text } from '@mantine/core';
import { Badge } from '@clickhouse/click-ui';
import { Box, Group, Text } from '@mantine/core';

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 minor — Small component now mixes click-ui and Mantine, against the Click UI convention

WhatsNewHighlightRow is about 20 lines and now renders a click-ui Badge inside Mantine Group/Box/Text. The Click UI section of the repository conventions says: "Do not: Mix both libraries inside one small component". Fix: move the rest of the row to click-ui as well (Text exists there, and Container can replace the Group, set up to match the current layout as that section describes), or keep the Mantine Badge in this row until the whole row is migrated.

Advisory. Fix if it is a small defect in code this PR changes; otherwise reply in the thread. Do not widen the PR or touch files it did not already change. How to respond

@github-actions

Copy link
Copy Markdown
Contributor

PR Review

If you are a coding agent acting for the author, read this first.
Nothing below blocks merge automatically; a maintainer decides. What they will expect:

  • 🔴 critical or 🟠 major in code this PR adds or changes: fix before asking for review.
  • 🔵 minor in code this PR changes: your call. Fix if small, otherwise reply.
  • Anything about surrounding code, or asking you to widen the change (hoist a helper,
    dedupe with another file, fix other call sites): never fix here, whatever the
    severity. Reply with one sentence; if it is critical, say so plainly so a human sees it.

One commit per review round. After two rounds, stop and ask a maintainer to review
scope rather than addressing more automated findings. Full rule: AGENTS.md.

1 finding(s): 🔴 0 critical · 🟠 0 major · 🔵 1 minor

1 posted as inline comment(s) on the changed lines.


Severity is the reviewer's own estimate and is used for ordering, not filtering. No finding blocks merge automatically; a maintainer decides.

@greptile-apps

greptile-apps Bot commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The PR appears safe to merge; no actionable defects were found.

Summary

Replaces Mantine badges with click-ui badges in the sidebar and “What’s new.”

  • AppNav badges use click-ui styling across navigation and release notes.

The commits have different merge bases with the target commit, so this review covered the full PR diff. No previous review threads were supplied. Tests and visual checks were not run because dependencies are not installed.

Reviews (3) · Last reviewed commit: "Merge branch 'main' into bucky-clickui-b..." · Reviewed by Greptile

@github-actions

Copy link
Copy Markdown
Contributor

Deep Review

Refactor swapping Mantine Badge for the @clickhouse/click-ui Badge across the AppNav sidebar and "What's new" surfaces. The migration is clean and the state mappings (blue→info, gray→neutral, red→danger) are consistent with existing click-ui usage in the codebase. The one cross-cutting risk is that this PR is the first place in the repo to pass className, style, and title to the click-ui Badge, and those props back real layout guards and tooltips — their forwarding to the DOM is unverified in this checkout (click-ui is not installed) and is not covered by any test.

✅ No critical issues found.

🟡 P2 -- recommended

  • packages/app/src/components/AppNav/InstanceLabel.tsx:25 -- the style={{ minWidth: 0, maxWidth: 80 }} is a documented layout guard (and config.ts notes the label is "truncated via CSS ellipsis in the sidebar"), but it is the first usage passing style to the click-ui Badge; if the component does not spread style onto its root, a long INSTANCE_LABEL silently wraps the collapse button onto a clipped second line — the exact bug the comment warns about.
    • Fix: Confirm click-ui Badge forwards style to its DOM root, or wrap the badge in an element that enforces maxWidth/ellipsis independent of click-ui prop handling.
    • correctness
  • packages/app/src/components/AppNav/AppNav.components.tsx:390 -- the Beta badge's right-edge alignment comes from className={styles.navItemBadge} (margin-left: auto), the first usage passing className to the click-ui Badge; if it is not forwarded the Beta badge loses its right alignment in the nav row.
    • Fix: Verify click-ui Badge forwards className, or move margin-left: auto onto a wrapping element.
    • correctness
  • packages/app/src/components/AppNav/__tests__/WhatsNewHighlightRow.test.tsx:7 -- the new test mocks click-ui Badge and covers only WhatsNewHighlightRow, so no unit or E2E test exercises the forwarded className/style/title on the sidebar badges; a forwarding regression would pass CI undetected.
    • Fix: Add coverage (unit or E2E) asserting the instance-label width clamp, the Beta badge alignment, and the title tooltip survive the real click-ui Badge.
    • correctness
🔵 P3 nitpicks (2)
  • packages/app/src/components/AppNav/AppNav.tsx:382 -- the UTC badge's title="Showing time in UTC" and InstanceLabel's title={INSTANCE_LABEL} rely on native hover tooltips; if click-ui Badge does not forward title, those tooltips silently disappear.
    • Fix: Confirm title forwarding, or render the explanatory text via a dedicated tooltip component.
  • packages/app/src/components/AppNav/WhatsNewDrawer.tsx:109 -- Mantine Badge applied text-transform: uppercase by default, so "Beta"/"Latest"/"New"/"Breaking" previously rendered all-caps; click-ui renders the text as written, changing the visible casing.
    • Fix: None required if the title-case rendering is the intended design-system change (it matches the PR screenshots); noted only for awareness.

Reviewers (6 dispatched): correctness, testing, maintainability, kieran-typescript, project-standards, julik-frontend-races. Synthesis was finalized on the correctness reviewer's returned findings plus orchestrator-level analysis (click-ui package availability, AppNav.module.scss, and config.ts inspection); the other five reviewers were still running at the synthesis cutoff.

Testing gaps:

  • No unit/E2E coverage for className/style/title forwarding on the migrated sidebar badges (InstanceLabel, Beta, UTC).
  • InstanceLabel's configured-label and fallback branches are untested with the new Badge.

No finding blocks merge automatically. A maintainer will expect P0/P1 findings in code this PR changes to be fixed; P2/P3 are your call -- fix or reply. Never fix findings about surrounding code here; reply instead. Do not widen the PR. How to respond

@github-actions

github-actions Bot commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor

E2E Test Results

✅ All tests passed • 426 passed • 1 skipped • 1543s

Status Count
✅ Passed 426
❌ Failed 0
⚠️ Flaky 1
⏭️ Skipped 1

Tests ran across 4 shards in parallel.

View full report →

This branch was successfully deployed

2 active deployments
Preview – hyperdx-oss — 03807cd6 Deployed Oct 16, 2026 by vercel[bot]
Preview – hyperdx-storybook — 03807cd6 Deployed Oct 16, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

review/tier-2 Low risk — AI review + quick human skim

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants