Repository navigation
refactor: update AppNav to use click-ui badges - #3378
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🦋 Changeset detectedLatest commit: 03807cd The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
🔵 Tier 2 — Low RiskSmall, isolated change with no API route or data model modifications. Why this tier:
Review process: AI review + quick human skim (target: 5–15 min). Reviewer validates AI assessment and checks for domain-specific concerns. Stats
|
Duplicate code analysisNo new duplicate code introduced by this PR. jscpd compared this branch against |
| @@ -1,4 +1,5 @@ | |||
| import { Badge, Box, Group, Text } from '@mantine/core'; | |||
| import { Badge } from '@clickhouse/click-ui'; | |||
| import { Box, Group, Text } from '@mantine/core'; | |||
There was a problem hiding this comment.
🔵 minor — Small component now mixes click-ui and Mantine, against the Click UI convention
WhatsNewHighlightRow is about 20 lines and now renders a click-ui Badge inside Mantine Group/Box/Text. The Click UI section of the repository conventions says: "Do not: Mix both libraries inside one small component". Fix: move the rest of the row to click-ui as well (Text exists there, and Container can replace the Group, set up to match the current layout as that section describes), or keep the Mantine Badge in this row until the whole row is migrated.
Advisory. Fix if it is a small defect in code this PR changes; otherwise reply in the thread. Do not widen the PR or touch files it did not already change. How to respond
PR Review
1 finding(s): 🔴 0 critical · 🟠 0 major · 🔵 1 minor 1 posted as inline comment(s) on the changed lines. Severity is the reviewer's own estimate and is used for ordering, not filtering. No finding blocks merge automatically; a maintainer decides. |
[Medium impact] The PR appears safe to merge; no actionable defects were found. SummaryReplaces Mantine badges with click-ui badges in the sidebar and “What’s new.”
The commits have different merge bases with the target commit, so this review covered the full PR diff. No previous review threads were supplied. Tests and visual checks were not run because dependencies are not installed. Reviews (3) · Last reviewed commit: "Merge branch 'main' into bucky-clickui-b..." · Reviewed by Greptile |
Deep ReviewRefactor swapping Mantine ✅ No critical issues found. 🟡 P2 -- recommended
🔵 P3 nitpicks (2)
Reviewers (6 dispatched): correctness, testing, maintainability, kieran-typescript, project-standards, julik-frontend-races. Synthesis was finalized on the correctness reviewer's returned findings plus orchestrator-level analysis (click-ui package availability, Testing gaps:
No finding blocks merge automatically. A maintainer will expect P0/P1 findings in code this PR changes to be fixed; P2/P3 are your call -- fix or reply. Never fix findings about surrounding code here; reply instead. Do not widen the PR. How to respond |
E2E Test Results✅ All tests passed • 426 passed • 1 skipped • 1543s
Tests ran across 4 shards in parallel. |
Summary
Screenshots or video
How to reproduce