Repository navigation
fix: persist filter expand state upon scrolling - #3377
Conversation
🦋 Changeset detectedLatest commit: 8e451b2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🔵 Tier 2 — Low RiskSmall, isolated change with no API route or data model modifications. Why this tier:
Review process: AI review + quick human skim (target: 5–15 min). Reviewer validates AI assessment and checks for domain-specific concerns. Stats
|
Duplicate code analysisNo new duplicate code introduced by this PR. jscpd compared this branch against |
PR Review
2 finding(s): 🔴 0 critical · 🟠 0 major · 🔵 2 minor 2 posted as inline comment(s) on the changed lines. Severity is the reviewer's own estimate and is used for ordering, not filtering. No finding blocks merge automatically; a maintainer decides. |
[Medium impact] The PR appears safe to merge; no new actionable issues were found. SummaryKeeps nested filters expanded or collapsed after their rows leave the screen and return.
Reviews (3) · Last reviewed commit: "persist distributions" · Reviewed by Greptile |
Deep ReviewPersisting child filter expand/ ✅ No critical issues found. 🟡 P2 — recommended
🔵 P3 nitpicks (3)
Reviewers (6): correctness, testing, maintainability, kieran-typescript, julik-frontend-races, previous-comments. Testing gaps:
No finding blocks merge automatically. A maintainer will expect P0/P1 findings in code this PR changes to be fixed; P2/P3 are your call -- fix or reply. Never fix findings about surrounding code here; reply instead. Do not widen the PR. How to respond |
E2E Test Results✅ All tests passed • 415 passed • 1 skipped • 1734s
Tests ran across 4 shards in parallel. |
Summary
Persists filter expand state upon a scroll in and out of view.
Screenshots or video
Before
export-1792073549803.mp4
After
export-1792073420807.mp4
How to test on Vercel preview
Steps:
References