Repository navigation
feat: Support source remapping during ad hoc filter import - #3367
Conversation
🦋 Changeset detectedLatest commit: afeba95 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Duplicate code analysisNo new duplicate code introduced by this PR. jscpd compared this branch against |
|
E2E Test Results✅ All tests passed • 415 passed • 1 skipped • 1235s
Tests ran across 4 shards in parallel. |
54a6a2b to
0566292
Compare
🟡 Tier 3 — StandardIntroduces new logic, modifies core functionality, or touches areas with non-trivial risk. Why this tier:
Review process: Full human review — logic, architecture, edge cases. Stats
|
PR Review
1 finding(s): 🔴 0 critical · 🟠 0 major · 🔵 1 minor 1 posted as inline comment(s) on the changed lines. Severity is the reviewer's own estimate and is used for ordering, not filtering. No finding blocks merge automatically; a maintainer decides. |
Deep Review✅ No critical issues found. The ad hoc source-remapping flow is type-correct end to end, the four prior Greptile findings about remap ordering (replace-in-place, fill-unresolved-by-position, successive remaps, and the Title Case label) are all addressed, and 🟡 P2 — recommended
🔵 P3 nitpicks (3)
Reviewers (7): correctness, julik-frontend-races, previous-comments, kieran-typescript, testing, maintainability, project-standards. Testing gaps:
No finding blocks merge automatically. A maintainer will expect P0/P1 findings in code this PR changes to be fixed; P2/P3 are your call -- fix or reply. Never fix findings about surrounding code here; reply instead. Do not widen the PR. How to respond |
0566292 to
ea474d5
Compare
| <Table.Tr> | ||
| <Table.Th>Tile / Filter</Table.Th> | ||
| <Table.Th>Mapping Type</Table.Th> | ||
| <Table.Th>Mapping type</Table.Th> |
There was a problem hiding this comment.
Updated a few labels to sentence case while I was here.
brandon-pereira
left a comment
There was a problem hiding this comment.
Code looks good, I was able to import. LGTM
Summary
This PR updates the dashboard import page to allow ad hoc filter sources (both sources and appliesToSources) re-mappable during import.
Note: adhoc filters are not yet rendered, so you won't see imported filters show up in the UI yet.
Screenshots or video
How to test
Here's an importable template to try
Save it as a JSON file and import it
References