Skip to content

refactor: change KubernetesDashboardPage to use click-ui badges - #3363

Merged
hoorayimhelping merged 3 commits into
mainfrom
bucky-clickui-badge-kube-dashboard-page
Oct 14, 2026
Merged

hoorayimhelping merged 3 commits into
mainfrom
bucky-clickui-badge-kube-dashboard-page

Conversation

@hoorayimhelping

Copy link
Copy Markdown
Member

Summary

  • All status badges on the Kubernetes dashboard page now use click-ui badges

Screenshots or video

1-pods-table 2-pod-drawer-events 3-nodes-table 4-node-drawer 5-namespaces-table 6-namespace-drawer

How to test on Vercel preview

Preview routes:

  1. From the navigation:
    a. Click Dashboards in the left navigation.
    b. Under Preset Dashboards, click Kubernetes.
  2. With the search shortcut: Press Cmd+K, type Kubernetes (or pods), and press Enter.
  3. By URL: Go to /kubernetes.

Steps:

  1. Pods table: Status badges show Running in green (success).
  2. Pod drawer: Click a pod row. In Latest Pod Events, event badges show Normal in green and Warning in orange. The text is in normal case, not capitals.
  3. Nodes tab: Status badges show Ready in green. Click a node row. The drawer header shows a green Ready badge, and its pods table shows green Running badges.
  4. Namespaces tab: Phase badges show Ready in green. Click a namespace row. The drawer header shows a green Ready badge.

References

  • Linear Issue:
  • Related PRs:

@vercel

vercel Bot commented Oct 13, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
hyperdx-oss Ready Ready Preview Oct 14, 2026 1:57pm UTC
hyperdx-storybook Ready Ready Preview Oct 14, 2026 1:57pm UTC

Request Review

@github-actions github-actions Bot added the review/tier-2 Low risk — AI review + quick human skim label Oct 13, 2026
@github-actions

Copy link
Copy Markdown
Contributor

🔵 Tier 2 — Low Risk

Small, isolated change with no API route or data model modifications.

Why this tier:

  • Standard feature/fix — introduces new logic or modifies core functionality

Review process: AI review + quick human skim (target: 5–15 min). Reviewer validates AI assessment and checks for domain-specific concerns.
SLA: Resolve within 4 business hours.

Stats
  • Production files changed: 4
  • Production lines changed: 136 (+ 32 in test files, excluded from tier calculation)
  • Branch: bucky-clickui-badge-kube-dashboard-page
  • Author: hoorayimhelping

To override this classification, remove the review/tier-2 label and apply a different review/tier-* label. Manual overrides are preserved on subsequent pushes.

@@ -152,13 +153,10 @@ const renderKubeEvent = (source: TLogSource) => (event: KubeEvent) => {
</Text>
{event['object.type'] && (
<Badge

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 minor — renderKubeEvent mixes the click-ui Badge with Mantine Group/Text/Timeline in one small render function

The base-branch Click UI convention says "Do not mix both libraries inside one small component". Either keep the Mantine Badge here, using semantic-token styling, or move the whole event row to click-ui (Container/Text).

Advisory. Fix if it is a small defect in code this PR changes; otherwise reply in the thread. Do not widen the PR or touch files it did not already change. How to respond

>
Ready
</Badge>
<Badge text="Ready" state="success" />

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 minor — Ready/Not Ready badge pair is hand-copied at four call sites

Add a FormatReadyStatus({ ready, notReadyLabel }) next to FormatPodStatus in components/KubeComponents.tsx. Use it here, in NamespaceDetailsSidePanel.tsx:106, and at KubernetesDashboardPage.tsx:691/873. That gives the state mapping one source of truth and one test, the same way FormatPodStatus does.

Advisory. Fix if it is a small defect in code this PR changes; otherwise reply in the thread. Do not widen the PR or touch files it did not already change. How to respond

@github-actions

Copy link
Copy Markdown
Contributor

PR Review

If you are a coding agent acting for the author, read this first.
Nothing below blocks merge automatically; a maintainer decides. What they will expect:

  • 🔴 critical or 🟠 major in code this PR adds or changes: fix before asking for review.
  • 🔵 minor in code this PR changes: your call. Fix if small, otherwise reply.
  • Anything about surrounding code, or asking you to widen the change (hoist a helper,
    dedupe with another file, fix other call sites): never fix here, whatever the
    severity. Reply with one sentence; if it is critical, say so plainly so a human sees it.

One commit per review round. After two rounds, stop and ask a maintainer to review
scope rather than addressing more automated findings. Full rule: AGENTS.md.

2 finding(s): 🔴 0 critical · 🟠 0 major · 🔵 2 minor

2 posted as inline comment(s) on the changed lines.


Severity is the reviewer's own estimate and is used for ordering, not filtering. No finding blocks merge automatically; a maintainer decides.

@github-actions

github-actions Bot commented Oct 13, 2026 •

Copy link
Copy Markdown
Contributor

Duplicate code analysis

1 new clone introduced by this PR.

  • packages/app/src/NamespaceDetailsSidePanel.tsx:1-24 ↔ packages/app/src/NodeDetailsSidePanel.tsx:1-24 — 24 lines

If one of these duplicates a helper that already exists, import it instead
of redefining it. If the duplication is deliberate, ignore this comment —
the check is advisory and never fails the build.


jscpd compared this branch against origin/main
across app, api and common-utils. Only new clones are listed; the codebase
currently holds 124 in total (1.72%).
Run yarn dupes locally to reproduce, or yarn dupes:all for the full picture.

@greptile-apps

greptile-apps Bot commented Oct 13, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 4/5

[Medium impact] Replaces badge component library across Kubernetes dashboard UI.

The two previously reported repository requirements still need to be satisfied before merging.

Fix All in Claude CodeFindings

  1. P2 Event row mixes UI libraries ▶
  2. P2 Status labels break sentence case ▶

Summary

The PR replaces Kubernetes status badges with click-ui badges.

  • Kubernetes dashboard badges now use click-ui.

Reviews (3) · Last reviewed commit: "Merge branch 'main' into bucky-clickui-b..." · Reviewed by Greptile

Comment on lines 155 to +159
<Badge
variant="light"
size="xs"
fw="normal"
color={event['object.type'] === 'Normal' ? 'green' : 'yellow'}
>
{event['object.type']}
</Badge>
size="sm"
text={event['object.type']}
state={event['object.type'] === 'Normal' ? 'success' : 'warning'}
/>

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Event row mixes UI libraries

renderKubeEvent now combines a click-ui Badge with Mantine Group and Text in the same small renderer. The repository guide says, “Do not: Mix both libraries inside one small component.” Move the event row into a small click-ui component so its text, badge, and spacing use one library. This repository requirement must be satisfied before merging.

Context Used: AGENTS.md (source)

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

Fix in Claude Code Fix in Conductor Fix in Cursor Fix in Codex

@github-actions

Copy link
Copy Markdown
Contributor

Deep Review

✅ No critical issues found.

This is a mechanical swap of the Mantine Badge for the click-ui Badge across the Kubernetes dashboard and its drawers. Independent verification confirmed the five state values used (success, danger, warning, info, neutral) are all valid click-ui states already used elsewhere in the app, the event badge's text is guarded against undefined, and the new FormatPodStatus test follows the existing passing AlertStateBadge.test.tsx pattern (global renderWithMantine, click-ui mock, React.ReactNode type without a React import) so it compiles and runs. No P2-level issues introduced by this diff.

🔵 P3 nitpicks (2)
  • packages/app/src/components/KubeComponents.tsx:330 — the explicit case KubePhase.Unknown: arm returns the same Badge as the default: arm, a redundant branch (pre-existing, unchanged by this diff).
    • Fix: Drop the KubePhase.Unknown case and let default: handle the neutral badge.
  • packages/app/src/KubernetesDashboardPage.tsx:906 — the non-ready namespace phase renders as Terminating here but as Not Ready in NamespaceDetailsSidePanel.tsx:123 for the same underlying phase !== 1 state (pre-existing; both labels are byte-identical before and after this PR).
    • Fix: Align the table and drawer on one label for the non-ready namespace phase.

Reviewers (5): correctness, testing, maintainability, kieran-typescript, project-standards.

Testing gaps: The badge changes in renderKubeEvent, NodesTable, and NamespacesTable have no new unit tests; these are pure prop swaps of unchanged conditions, so the gap is low-value. Note: the correctness, kieran-typescript, and project-standards reviewers had not returned at synthesis time; their domains (valid Badge states, compile-time type safety, test well-formedness, changeset format) were independently verified clean.

No finding blocks merge automatically. A maintainer will expect P0/P1 findings in code this PR changes to be fixed; P2/P3 are your call -- fix or reply. Never fix findings about surrounding code here; reply instead. Do not widen the PR. How to respond

@github-actions

github-actions Bot commented Oct 13, 2026 •

Copy link
Copy Markdown
Contributor

E2E Test Results

✅ All tests passed • 411 passed • 1 skipped • 1252s

Status Count
✅ Passed 411
❌ Failed 0
⚠️ Flaky 0
⏭️ Skipped 1

Tests ran across 4 shards in parallel.

View full report →

@pulpdrew pulpdrew left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@changeset-bot

changeset-bot Bot commented Oct 14, 2026 •

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 29b47f9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@hyperdx/app Patch
@hyperdx/api Patch
@hyperdx/otel-collector Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

>
Not Ready
</Badge>
<Badge text="Not Ready" state="danger" />

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Status labels break sentence case

The replacement Badge uses Not Ready, but the repository requires sentence case for static user-facing text. Change it to Not ready here and in the node and namespace drawers. This repository requirement must be satisfied before merging.

Context Used: AGENTS.md (source)

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

Fix in Claude Code Fix in Conductor Fix in Cursor Fix in Codex

This branch was successfully deployed

2 active deployments
Preview – hyperdx-oss — 29b47f98 Deployed Oct 14, 2026 by vercel[bot]
Preview – hyperdx-storybook — 29b47f98 Deployed Oct 14, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

review/tier-2 Low risk — AI review + quick human skim

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants