Skip to content

refactor: remove TableConnection; pass sources instead - #3349

Draft
knudtty wants to merge 1 commit into
mainfrom
aaron/remove-table-connections
Draft

knudtty wants to merge 1 commit into
mainfrom
aaron/remove-table-connections

Conversation

@knudtty

@knudtty knudtty commented Oct 9, 2026

Copy link
Copy Markdown
Contributor

Summary

Screenshots or video

Before After

How to test on Vercel preview

Preview routes:

Steps:

References

  • Linear Issue:
  • Related PRs:

@changeset-bot

changeset-bot Bot commented Oct 9, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 761f214

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@hyperdx/common-utils Minor
@hyperdx/app Patch
@hyperdx/api Patch
@hyperdx/otel-collector Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercel Bot commented Oct 9, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
hyperdx-oss Ready Ready Preview Oct 9, 2026 9:13pm UTC
hyperdx-storybook Ready Ready Preview Oct 9, 2026 9:13pm UTC

Request Review

@github-actions

github-actions Bot commented Oct 9, 2026

Copy link
Copy Markdown
Contributor

Duplicate code analysis

5 new clones introduced by this PR.

  • packages/app/src/NamespaceDetailsSidePanel.tsx:1-24 ↔ packages/app/src/NodeDetailsSidePanel.tsx:1-24 — 24 lines
  • packages/app/src/NamespaceDetailsSidePanel.tsx:240-270 ↔ packages/app/src/NodeDetailsSidePanel.tsx:253-283 — 31 lines
  • packages/app/src/NamespaceDetailsSidePanel.tsx:240-270 ↔ packages/app/src/PodDetailsSidePanel.tsx:243-273 — 31 lines
  • packages/app/src/components/Sources/SourceForm/LogTableModelForm.tsx:5-28 ↔ packages/app/src/components/Sources/SourceForm/TraceTableModelForm.tsx:4-27 — 24 lines
  • packages/app/src/llm/hooks/useLLMDashboardExpressions.ts:12-25 ↔ packages/app/src/llm/hooks/useLLMDashboardExpressions.ts:33-46 — 14 lines

If one of these duplicates a helper that already exists, import it instead
of redefining it. If the duplication is deliberate, ignore this comment —
the check is advisory and never fails the build.


jscpd compared this branch against origin/main
across app, api and common-utils. Only new clones are listed; the codebase
currently holds 124 in total (1.75%).
Run yarn dupes locally to reproduce, or yarn dupes:all for the full picture.

@github-actions

github-actions Bot commented Oct 9, 2026

Copy link
Copy Markdown
Contributor

E2E Test Results

❌ Error reading test results: ENOENT: no such file or directory, scandir 'all-test-results'

View full report →

@greptile-apps

greptile-apps Bot commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

[Medium impact] The PR appears safe to merge; no actionable issues were found.

Summary

Replaces TableConnection with sources throughout field discovery.

  • Field discovery follows each source and its table settings.
  • SQL editors and chart fields can resolve metric-specific tables.
  • Facet suggestions use source details to find the right table.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart LR
  A["Search and SQL editors"] --> B["Source + metric type/name"]
  B --> C["Field discovery hooks"]
  C --> D["Metadata.getAllFields"]
  D --> E["getSourceTable"]
  E --> F["ClickHouse table"]
  D --> G["Source timestamp and metadata views"]
  G --> H["Map key discovery"]
  F --> H
Loading

Reviews (1) · Last reviewed commit: "refactor: remove TableConnection; pass s..." · Reviewed by Greptile

This branch was successfully deployed

2 active deployments
Preview – hyperdx-oss — 761f2145 Deployed Oct 9, 2026 by vercel[bot]
Preview – hyperdx-storybook — 761f2145 Deployed Oct 9, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant