Repository navigation
feat: stream filter keys and value results to UI - #3348
Conversation
🦋 Changeset detectedLatest commit: 73c8f2a The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Duplicate code analysisNo new duplicate code introduced by this PR. jscpd compared this branch against |
[Medium impact] The PR appears safe to merge; no new actionable issue was established. SummaryFilter keys now appear before their values. Values arrive as each lookup finishes, with a loader on filters still waiting.
Previous threads: the findings about quoted-key loaders, saved metadata settings, cached exact results, and duplicated filter types were manually resolved without explanation. The header-color thread was also resolved;
|
E2E Test Results✅ All tests passed • 430 passed • 1 skipped • 1784s
Tests ran across 4 shards in parallel. |
…ey-value-results # Conflicts: # packages/app/src/components/DBSearchPageFilters/hooks.test.tsx # packages/app/src/hooks/useMetadata.tsx
Drop the separate useAllKeyValues hook and stream 'all' mode through the existing useMultipleGetKeyValues query, restoring main's multi-source behavior (each source's own MVs, the single-source MVs override, limit, partial results when a source fails). Partial results only fill an empty panel; values already showing stay until the new result is complete, so filters don't blank out mid-use. Also return useFetchFacets' pendingKeys inside data.
80a6d11 to
f1b1c33
Compare
🟡 Tier 3 — StandardIntroduces new logic, modifies core functionality, or touches areas with non-trivial risk. Why this tier:
Review process: Full human review — logic, architecture, edge cases. Stats
|
PR Review
5 finding(s): 🔴 0 critical · 🟠 1 major · 🔵 4 minor 2 posted as inline comment(s) on the changed lines. 3 listed below. Findings outside the changed lines3 minor
Severity is the reviewer's own estimate and is used for ordering, not filtering. No finding blocks merge automatically; a maintainer decides. |
Deep ReviewStreams filter keys and value results to the filters sidebar: keys render first, then per-key values stream in as each metadata query completes. Reviewed against base 🔴 P0/P1 — must fix
🟡 P2 — recommended
🔵 P3 nitpicks (15)
Reviewers (11): correctness, adversarial, frontend-races, kieran-typescript, performance, reliability, api-contract, testing, maintainability, project-standards, previous-comments. Testing gaps:
No finding blocks merge automatically. A maintainer will expect P0/P1 findings in code this PR changes to be fixed; P2/P3 are your call -- fix or reply. Never fix findings about surrounding code here; reply instead. Do not widen the PR. How to respond |
pulpdrew
left a comment
There was a problem hiding this comment.
LGTM, very nice improvement
Summary
Filter queries no longer wait for all values to arrive. Values are streamed and the UI updates as keys and values arrive. It now behaves that:
Screenshots or video
Before
export-1791576561547.mp4
After
export-1791575968941.mp4
How to test on Vercel preview
Steps:
References