Skip to content

ci: Fix integration test output format - #3346

Merged
kodiakhq[bot] merged 2 commits into
mainfrom
claude/ci-int-unprefixed-output
Oct 9, 2026
Merged

kodiakhq[bot] merged 2 commits into
mainfrom
claude/ci-int-unprefixed-output

Conversation

@pulpdrew

@pulpdrew pulpdrew commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

Summary

This PR improves the formatting of integration test output in GH Actions by running tests directly instead of through nx, which streams its output, breaking text across lines in the Actions output log.

Before

Screenshot 2026-10-09 at 3 01 40 PM

After

Screenshot 2026-10-09 at 3 02 18 PM

Screenshots or video

How to test on Vercel preview

References

  • Linear Issue:
  • Related PRs:

@changeset-bot

changeset-bot Bot commented Oct 9, 2026 •

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: ef34105

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel

vercel Bot commented Oct 9, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
hyperdx-oss Ready Ready Preview Oct 9, 2026 7:45pm UTC
hyperdx-storybook Ready Ready Preview Oct 9, 2026 7:45pm UTC

Request Review

@github-actions

github-actions Bot commented Oct 9, 2026

Copy link
Copy Markdown
Contributor

Duplicate code analysis

No new duplicate code introduced by this PR.


jscpd compared this branch against origin/main
across app, api and common-utils. Only new clones are listed; the codebase
currently holds 125 in total (1.75%).
Run yarn dupes locally to reproduce, or yarn dupes:all for the full picture.

@pulpdrew
pulpdrew marked this pull request as ready for review October 9, 2026 19:02
@github-actions github-actions Bot added the review/tier-1 Trivial — auto-merge candidate once CI passes label Oct 9, 2026
@github-actions

github-actions Bot commented Oct 9, 2026

Copy link
Copy Markdown
Contributor

🟢 Tier 1 — Trivial

Docs, images, lock files, a dependency bump, or an automated release. No functional code changes detected.

Why this tier:

  • All files are docs / images / lock files

Additional context: touches background tasks or the delivery pipeline lightly (13 lines, under the 30-line bar for Tier 4)

Review process: Auto-merge once CI passes. No human review required.
SLA: Resolves automatically.

Stats
  • Production files changed: 0
  • Production lines changed: 0
  • Branch: claude/ci-int-unprefixed-output
  • Author: pulpdrew

To override this classification, remove the review/tier-1 label and apply a different review/tier-* label. Manual overrides are preserved on subsequent pushes.

Comment thread .github/workflows/main.yml Resolved
@github-actions

github-actions Bot commented Oct 9, 2026

Copy link
Copy Markdown
Contributor

PR Review

If you are a coding agent acting for the author, read this first.
Nothing below blocks merge automatically; a maintainer decides. What they will expect:

  • 🔴 critical or 🟠 major in code this PR adds or changes: fix before asking for review.
  • 🔵 minor in code this PR changes: your call. Fix if small, otherwise reply.
  • Anything about surrounding code, or asking you to widen the change (hoist a helper,
    dedupe with another file, fix other call sites): never fix here, whatever the
    severity. Reply with one sentence; if it is critical, say so plainly so a human sees it.

One commit per review round. After two rounds, stop and ask a maintainer to review
scope rather than addressing more automated findings. Full rule: AGENTS.md.

1 finding(s): 🔴 0 critical · 🟠 0 major · 🔵 1 minor

1 posted as inline comment(s) on the changed lines.


Severity is the reviewer's own estimate and is used for ordering, not filtering. No finding blocks merge automatically; a maintainer decides.

@greptile-apps

greptile-apps Bot commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

[High impact] The PR appears safe to merge.

Summary

The PR runs integration tests through Yarn workspaces instead of nx to keep GitHub Actions logs readable.

  • Integration test logs keep Jest output readable across both packages.

Reviews (2) · Last reviewed commit: "Merge branch 'main' into claude/ci-int-u..." · Reviewed by Greptile

@github-actions

github-actions Bot commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

E2E Test Results

✅ All tests passed • 407 passed • 1 skipped • 1312s

Status Count
✅ Passed 407
❌ Failed 0
⚠️ Flaky 1
⏭️ Skipped 1

Tests ran across 4 shards in parallel.

View full report →

@github-actions

github-actions Bot commented Oct 9, 2026

Copy link
Copy Markdown
Contributor

Deep Review

✅ No critical issues found.

This change swaps nx run-many -t ci:int for two explicit yarn workspace … ci:int invocations with shell-level status aggregation. The replacement was verified behavior-preserving on every axis: Yarn 4 (Berry) forwards the trailing --shard=${{ matrix.shard }}/${{ strategy.job-total }} token straight to jest; a repo-wide grep confirms @hyperdx/common-utils and @hyperdx/api are the only two packages defining a ci:int script, so no suite is dropped or added; under the Actions default bash -eo pipefail shell the cmd || status=1 guards keep set -e from aborting between the two runs, so both always execute and exit $status propagates either failure; and dependency building is unchanged because ci:int has no dependsOn in nx.json and the preceding make ci-build step still runs.

🔵 P3 nitpicks (1)
  • .github/workflows/main.yml:148 — Enumerating @hyperdx/common-utils and @hyperdx/api explicitly drops nx's runtime discovery of every workspace with a ci:int target, so a package that later adds an integration suite is silently skipped while the shard stays green.
    • Fix: Add a one-line comment at the two yarn workspace lines stating the list must be updated whenever a package gains a ci:int script.
    • project-standards, maintainability

Reviewers (3): correctness, project-standards/maintainability, previous-comments.

No finding blocks merge automatically. A maintainer will expect P0/P1 findings in code this PR changes to be fixed; P2/P3 are your call -- fix or reply. Never fix findings about surrounding code here; reply instead. Do not widen the PR. How to respond

@kodiakhq
kodiakhq Bot merged commit 0b9153d into main Oct 9, 2026
29 checks passed
@kodiakhq
kodiakhq Bot deleted the claude/ci-int-unprefixed-output branch October 9, 2026 19:49

This branch was successfully deployed

2 active deployments
Preview – hyperdx-oss — ef34105e Deployed Oct 9, 2026 by vercel[bot]
Preview – hyperdx-storybook — ef34105e Deployed Oct 9, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automerge review/tier-1 Trivial — auto-merge candidate once CI passes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants