Repository navigation
refactor: useMultipleAllFields returns each table connection's fields, columns, and error - #3344
Conversation
🦋 Changeset detectedLatest commit: dd3ae90 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🔵 Tier 2 — Low RiskSmall, isolated change with no API route or data model modifications. Why this tier:
Review process: AI review + quick human skim (target: 5–15 min). Reviewer validates AI assessment and checks for domain-specific concerns. Stats
|
Duplicate code analysisNo new duplicate code introduced by this PR. jscpd compared this branch against |
PR Review
2 finding(s): 🔴 0 critical · 🟠 0 major · 🔵 2 minor None could be anchored to changed lines; they are listed below. Findings outside the changed lines2 minor
Severity is the reviewer's own estimate and is used for ordering, not filtering. No finding blocks merge automatically; a maintainer decides. |
|
Deep ReviewRefactor of ✅ No critical issues found. The prior 🔵 P3 nitpicks (3)
Reviewers (9): correctness, adversarial, kieran-typescript, reliability, api-contract, testing, maintainability, previous-comments, project-standards. Testing gaps: none substantive — new per-connection error, all-fail, intersect-fail-closed, metadata-disabled, reference-stability, and caller-facing error paths are all covered. No finding blocks merge automatically. A maintainer will expect P0/P1 findings in code this PR changes to be fixed; P2/P3 are your call -- fix or reply. Never fix findings about surrounding code here; reply instead. Do not widen the PR. How to respond |
E2E Test Results✅ All tests passed • 408 passed • 1 skipped • 1295s
Tests ran across 4 shards in parallel. |
2da05c2 to
febb95f
Compare
…, columns, and error
febb95f to
86bfb5b
Compare
Summary
This PR makes a few changes to the
useMultipleAllFieldshook (used to fetch columns and map keys for search filters).Limitations before:
Changes to eliminate these limitations:
fieldsByTableConnectionso that the caller can find which table connection each field came fromerrorsByTableConnectionand (when all connections error) anerrorandisErrorresult.columnsByTableConnectionandisFieldMetadataDisabledallowing callers to use the list of columns even when the team's isFieldMetadataDisabled is true.Screenshots or video
This is a refactor, no changes are expected EXCEPT the search page will now show an error toast when filters fail to fetch (since the hook now returns an error state in that case).
How to test on Vercel preview
Play around with search filters and autocomplete to ensure that nothing has regressed
References