Repository navigation
Conversation
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Duplicate code analysis1 new clone introduced by this PR.
If one of these duplicates a helper that already exists, import it instead jscpd compared this branch against |
|
| expect(call.clickhouse_settings).not.toHaveProperty( | ||
| 'enable_filesystem_cache', | ||
| ); |
There was a problem hiding this comment.
| const values = byKey(await getValues('all')); | ||
|
|
||
| expect(values["LogAttributes['shared']"]?.sort()).toEqual([ | ||
| 'from-big', | ||
| 'from-new', | ||
| ]); |
There was a problem hiding this comment.
All-mode test misses the difference
The 'all' integration test uses only two indexed parts. The default path already selects both: the largest and the newest. Both tests therefore expect the same values, so this test would still pass if 'all' accidentally used the default path. Add a third indexed part with a unique value, and check that only 'all' returns it.
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
| (mockClickhouseClient.query as jest.Mock).mock.calls.find((c: any[]) => | ||
| (c[0].query as string).includes('keys_catalog_'), |
There was a problem hiding this comment.
The new mock-call callbacks explicitly use any[]. The repository guide says “Avoid any — use proper typing.” Give these calls a named query-argument type, or use the mock's inferred callback types. The same pattern appears in the new query-list callback. This typing requirement must be satisfied before merging.
Context Used: AGENTS.md (source)
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
| maxValuesPerKey: LOAD_MORE_LOAD_LIMIT, | ||
| // One key, so reading every part that holds it stays cheap, and | ||
| // the best part alone may hold far fewer values than requested. | ||
| mapTextIndexPartsPerKey: 'all', |
There was a problem hiding this comment.
Filter fix lacks release entry
This changes how users load filter values, but the PR has no changeset. AGENTS.md requires a changeset for behavior changes to @hyperdx/app. Add a patch changeset before merging so the fix is included in the release.
Context Used: AGENTS.md (source)
E2E Test Results✅ All tests passed • 406 passed • 1 skipped • 1451s
Tests ran across 4 shards in parallel. |
Summary
Screenshots or video
How to test on Vercel preview
Preview routes:
Steps:
References