Repository navigation
Conversation
|
@mrkaye97 is attempting to deploy a commit to the HyperDX Team on Vercel. A member of the Team first needs to authorize it. |
🦋 Changeset detectedLatest commit: 4eb4363 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Hi @mrkaye97, thanks for the pull request! Before we review code from a first-time contributor we ask that a maintainer vouches for you, and you're not on our list yet. This PR stays open — it just isn't in the review queue until someone vouches. To get vouched, open an issue saying hello and what you're working on: https://github.com/hyperdxio/hyperdx/issues/new?template=introduce-yourself.md A maintainer will usually reply within a day or two, and then this PR gets picked up as normal. More detail in our contributing guide. |
PR Review
1 finding(s): 🔴 0 critical · 🟠 0 major · 🔵 1 minor 1 posted as inline comment(s) on the changed lines. Severity is the reviewer's own estimate and is used for ordering, not filtering. No finding blocks merge automatically; a maintainer decides. |
|
Deep Review✅ No critical issues found. This diff removes the Verification confirms the change is safe and behaviorally equivalent to simply adding
Reviewers (5): correctness, maintainability, testing, project-standards, previous-comments. Testing gaps: No automated test asserts |
| '12h', | ||
| '1d', | ||
| ]); | ||
| export const TILE_ALERT_INTERVAL_OPTIONS = ALERT_INTERVAL_OPTIONS; |
There was a problem hiding this comment.
just aliased this instead of refactoring everywhere in case we wanted them to diverge in the future, but happy to also remove TILE_ALERT_INTERVAL_OPTIONS and use ALERT_INTERVAL_OPTIONS everywhere instead!
| '12h', | ||
| '1d', | ||
| ]); | ||
| export const TILE_ALERT_INTERVAL_OPTIONS = ALERT_INTERVAL_OPTIONS; |
There was a problem hiding this comment.
🔵 minor — TILE_ALERT_INTERVAL_OPTIONS is now just another name for ALERT_INTERVAL_OPTIONS, so the tile/search branch in EditAlertModal does nothing
Delete the alias and use ALERT_INTERVAL_OPTIONS in its two callers. In packages/app/src/components/alerts/EditAlertModal.tsx:224-226, replace the isChartAlert ? TILE_ALERT_INTERVAL_OPTIONS : ALERT_INTERVAL_OPTIONS ternary (both branches are the same object) with ALERT_INTERVAL_OPTIONS. In packages/app/src/components/DBEditTimeChartForm/TileAlertEditor.tsx:47,88,224, switch the imports and uses to ALERT_INTERVAL_OPTIONS. As it stands, the code suggests tile alerts have their own interval list, but that list is now the same object as the general one.
Advisory. Fix if it is a small defect in code this PR changes; otherwise reply in the thread. Do not widen the PR or touch files it did not already change. How to respond
Summary
Adding a
1moption in non-dev environments for tile alert windows. Not sure if it was intentional to make this dev-only, but it'd be really nice for us to be able to use 1m as the window, because in conjunction with consecutive windows, this allows us to do something like 1m window over 5 consecutive windows, which AFAICT is a stricter condition than a single 5m window (1 consecutive), because we'd get 5 samples instead of aggregating across the entire window into one big sample (which means a very noisy single minute could trip a 5m window alert, but maybe not the second minute of five 1m window alerts).Not sure if this reasoning makes sense, so happy to explain more, and thanks!
Wasn't sure if a frontend-only change required a changeset, etc. or not - happy to add that