Repository navigation
ui: Extract FilterPill, add filter editor components - #3317
Conversation
🦋 Changeset detectedLatest commit: 6984a89 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
🟡 Tier 3 — StandardIntroduces new logic, modifies core functionality, or touches areas with non-trivial risk. Why this tier:
Review process: Full human review — logic, architecture, edge cases. Stats
|
Duplicate code analysisNo new duplicate code introduced by this PR. jscpd compared this branch against |
PR Review
4 finding(s): 🔴 0 critical · 🟠 0 major · 🔵 4 minor 1 posted as inline comment(s) on the changed lines. 3 listed below. Findings outside the changed lines3 minor
Severity is the reviewer's own estimate and is used for ordering, not filtering. No finding blocks merge automatically; a maintainer decides. |
|
Deep Review✅ No critical issues found. This PR extracts 🟡 P2 -- recommended
🔵 P3 nitpicks (4)
Reviewers (8): correctness, testing, maintainability, project-standards, kieran-typescript, julik-frontend-races, adversarial, previous-comments. Testing gaps:
No finding blocks merge automatically. A maintainer will expect P0/P1 findings in code this PR changes to be fixed; P2/P3 are your call -- fix or reply. Never fix findings about surrounding code here; reply instead. Do not widen the PR. How to respond |
E2E Test Results✅ All tests passed • 405 passed • 1 skipped • 1441s
Tests ran across 4 shards in parallel. |
| // (column missing on the active source) can only be removed. Both keep the | ||
| // plain remove-only pill; only included/excluded pills open the action menu. | ||
| // (column missing on the active source) can only be removed. | ||
| const isEditable = pill.type !== 'range' && !isInvalid; |
There was a problem hiding this comment.
🔵 minor — !isInvalid check repeats a guard that FilterPill already applies
FilterPill already sets isEditable = renderPopover != null && !isInvalid (FilterPill/FilterPill.tsx:968). In SearchFilterPill, isEditable only needs to be pill.type !== 'range' for deciding whether to pass renderPopover. Keep !isInvalid only in the enabled condition of useGetKeyValues, so the invalid-pill rule lives in one place.
Advisory. Fix if it is a small defect in code this PR changes; otherwise reply in the thread. Do not widen the PR or touch files it did not already change. How to respond
Summary
This PR extracts a FilterPill component from the ActiveFilterPills list component, and adds additional adhoc-filter-related components used to edit a filter's key, operator, and value. Storybooks are provided covering the new and existing functionality.
Screenshots or video
Screen.Recording.2026-10-07.at.11.25.26.AM.mov
How to test on Vercel preview
Regression testing on the search page: test adding a filter and editing its value in the pill
New functionality: view the storybook
References