Repository navigation
chore: convert AlertStateBadge to use click-ui badge - #3314
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🦋 Changeset detectedLatest commit: f27dfec The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
🔵 Tier 2 — Low RiskSmall, isolated change with no API route or data model modifications. Why this tier:
Review process: AI review + quick human skim (target: 5–15 min). Reviewer validates AI assessment and checks for domain-specific concerns. Stats
|
PR Review✅ No issues found. |
Duplicate code analysisNo new duplicate code introduced by this PR. jscpd compared this branch against |
|
Deep ReviewScope: converts 🔴 P0/P1 — must fix
Reviewers (6): correctness, testing, maintainability, project-standards, kieran-typescript, previous-comments. Testing gaps:
No finding blocks merge automatically. A maintainer will expect P0/P1 findings in code this PR changes to be fixed; P2/P3 are your call -- fix or reply. Never fix findings about surrounding code here; reply instead. Do not widen the PR. How to respond |
E2E Test Results✅ All tests passed • 407 passed • 1 skipped • 1410s
Tests ran across 4 shards in parallel. |
3453744 to
678b532
Compare
This seems incorrect to me. ~/Development/hyperdx/packages/app>yarn tsc --noEmit
~/Development/hyperdx/packages/app> |
elizabetdev
left a comment
There was a problem hiding this comment.
LGTM! 🎉
From a design perspective.
|
It looks a bit... sanitized. Are we able to keep the caps and potentially bold? |
Summary
Badgewith click-ui'sBadgein theAlertStateBadgecomponent, which shows up in the Alerts page.Screenshots or video
How to test on Vercel preview
https://example.com/hook). Click Add Webhook.References