Repository navigation
feat: Support PromQL heatmaps (series-mode) - #3313
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
🦋 Changeset detectedLatest commit: e1e4de9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
PR Review
1 finding(s): 🔴 0 critical · 🟠 1 major · 🔵 0 minor None could be anchored to changed lines; they are listed below. Findings outside the changed lines
Severity is the reviewer's own estimate and is used for ordering, not filtering. No finding blocks merge automatically; a maintainer decides. |
Deep Review✅ No critical issues found. The two P1 items raised in earlier review rounds are both verifiably addressed in the current diff: 🟡 P2 — recommended
🔵 P3 nitpicks (2)
Reviewers (10): correctness, adversarial, kieran-typescript, testing, maintainability, project-standards, julik-frontend-races, previous-comments, agent-native, learnings-researcher. Testing gaps: No end-to-end test asserts the multi-expression PromQL heatmap first-expression-only behavior through the No finding blocks merge automatically. A maintainer will expect P0/P1 findings in code this PR changes to be fixed; P2/P3 are your call -- fix or reply. Never fix findings about surrounding code here; reply instead. Do not widen the PR. How to respond |
|
a240f0d to
740b51b
Compare
teeohhem
left a comment
There was a problem hiding this comment.
just a merge conflict left
🔵 Tier 2 — Low RiskSmall, isolated change with no API route or data model modifications. Why this tier:
Review process: AI review + quick human skim (target: 5–15 min). Reviewer validates AI assessment and checks for domain-specific concerns. Stats
|
Duplicate code analysisNo new duplicate code introduced by this PR. jscpd compared this branch against |
E2E Test Results✅ All tests passed • 405 passed • 1 skipped • 1322s
Tests ran across 4 shards in parallel. |
Summary
This PR adds support for PromQL heatmaps in "series-mode" where the y-axis is the series.
Macros, variables, and legend templates work as expected. The query is range-only.
Screenshots or video
How to test locally
References