Repository navigation
feat: provision a PromQL source in the dev default sources - #3311
Conversation
🦋 Changeset detectedLatest commit: 439fdba The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
PR Review✅ No issues found. |
Duplicate code analysisNo new duplicate code introduced by this PR. jscpd compared this branch against |
Deep Review✅ No critical issues found. This is a small, well-scoped change: a 🔵 P3 nitpicks (1)
Reviewers (5): correctness, testing, maintainability, project-standards, kieran-typescript. Testing gaps:
No finding blocks merge automatically. A maintainer will expect P0/P1 findings in code this PR changes to be fixed; P2/P3 are your call -- fix or reply. Never fix findings about surrounding code here; reply instead. Do not widen the PR. How to respond |
|
E2E Test Results✅ All tests passed • 400 passed • 1 skipped • 1638s
Tests ran across 4 shards in parallel. |
pulpdrew
left a comment
There was a problem hiding this comment.
LGTM, this is very convenient
61e4f45 to
40c4f04
Compare
🔵 Tier 2 — Low RiskSmall, isolated change with no API route or data model modifications. Why this tier:
Review process: AI review + quick human skim (target: 5–15 min). Reviewer validates AI assessment and checks for domain-specific concerns. Stats
|
| logger.info( | ||
| `Skipping default source ${sourceConfig.name}: PromQL is disabled`, | ||
| ); |
There was a problem hiding this comment.
The new PromQL skip writes a countable log event but emits no metric or span attribute. The repository guide requires both for logged skips, so developers can count them and see the reason on the active span. Add these alongside the log before merging to satisfy that requirement.
Context Used: AGENTS.md (source)
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
40c4f04 to
439fdba
Compare
Summary
Auto-provisions a PromQL source for local dev.
default.metrics_tsto the devDEFAULT_SOURCES. The dev collector always runs the PromQL migration, so the table exists.setupTeamDefaultsskipsDEFAULT_SOURCESentries of kindpromqlunlessENABLE_PROMQL=true, so the source only appears with PromQL on.Tests: unit tests for
setupTeamDefaultswith PromQL on and off.How to test on Vercel preview
Set up a fresh dev env and check the PromQL source exists.
References