Repository navigation
feat(app): let users permanently dismiss the metric drill-down warning - #3304
Conversation
🦋 Changeset detectedLatest commit: 7ade709 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🔵 Tier 2 — Low RiskSmall, isolated change with no API route or data model modifications. Why this tier:
Review process: AI review + quick human skim (target: 5–15 min). Reviewer validates AI assessment and checks for domain-specific concerns. Stats
|
Duplicate code analysisNo new duplicate code introduced by this PR. jscpd compared this branch against |
PR Review
2 finding(s): 🔴 0 critical · 🟠 0 major · 🔵 2 minor 1 posted as inline comment(s) on the changed lines. 1 listed below. Findings outside the changed lines1 minor
Severity is the reviewer's own estimate and is used for ordering, not filtering. No finding blocks merge automatically; a maintainer decides. |
|
Deep ReviewScope: 1 production file ( ✅ No critical issues found. The core change is sound: Mantine v9 dedupes 🟡 P2 -- recommended
🔵 P3 nitpicks (4)
Reviewers (3): testing, maintainability, kieran-typescript (correctness and julik-frontend-races were dispatched but had not returned at synthesis time; Mantine dedup behavior and the prior greptile comment were verified directly). Testing gaps:
Residual risk: Dismissal is permanent and global across all metric sources lacking a correlated log source, with no in-app reset path — appears intentional per the change's goal, but worth a product sanity check. No finding blocks merge automatically. A maintainer will expect P0/P1 findings in code this PR changes to be fixed; P2/P3 are your call -- fix or reply. Never fix findings about surrounding code here; reply instead. Do not widen the PR. How to respond |
E2E Test Results✅ All tests passed • 399 passed • 1 skipped • 1451s
Tests ran across 4 shards in parallel. |
Summary
The "No log source is associated with the selected metric source" notification was noisy and didn't provide a great bit of info. I rephrased it to "Drill-down is unavailable for metric sources that lack correlated log sources". Additionally, if a user closes the notification, it is dismissed for future notifications. This is persisted in localStorage
Screenshots or video
References