Repository navigation
feat: Support series-mode heatmap in API and MCP - #3298
Conversation
🦋 Changeset detectedLatest commit: 0dece9f The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
PR Review
3 finding(s): 🔴 0 critical · 🟠 1 major · 🔵 2 minor 1 posted as inline comment(s) on the changed lines. 2 listed below. Findings outside the changed lines
1 minor
Severity is the reviewer's own estimate and is used for ordering, not filtering. No finding blocks merge automatically; a maintainer decides. |
|
Deep Review✅ No critical issues found. This PR cleanly extends heatmap support to a second mode across the external API, OpenAPI spec, and MCP surface. The core risk areas verified out well: the hand-rolled 🟡 P2 -- recommended
🔵 P3 nitpicks (7)
Reviewers (10): correctness, adversarial, testing, maintainability, project-standards, api-contract, kieran-typescript, previous-comments, agent-native, learnings-researcher. Note: the correctness, adversarial, and agent-native reviewers did not return before synthesis; their highest-stakes paths (schema routing, unknown-mode handling, round-trip fidelity, MCP parity) were independently verified against the code and corroborated by the TypeScript and API-contract reviewers. Testing gaps:
No finding blocks merge automatically. A maintainer will expect P0/P1 findings in code this PR changes to be fixed; P2/P3 are your call -- fix or reply. Never fix findings about surrounding code here; reply instead. Do not widen the PR. How to respond |
## Summary This PR adds a new heatmap "mode" in which the y-axis represents unique series (group-by values), the x-axis represents time, and the color is determined by an aggregate value over that group at that time bucket. This is analogous to a timeseries chart, where instead of plotting the value of each series on the y-axis, the value is plotted on the color axis. Consequently, the builder interface and resulting query looks very similar to those from the time chart implementation. When too many (>50) series are selected, a warning is shown, and only the top 50 series are shown (by the same math used for client-side time chart series limits. Notes: - MCP and External API support is deliberately missing, will be added in a subsequent PR The y-axis series labels are truncated when necessary, with a tooltip that shows the full results. ### Screenshots or video <img width="1833" height="1199" alt="Screenshot 2026-10-05 at 9 24 48 AM" src="https://github.com/user-attachments/assets/1e969db7-104c-46e0-8a24-d9c406345df7" /> ### How to test on Vercel preview Create some series-mode heatmaps ### References - Linear Issue: Closes HDX-5607 - Related PRs: #3298
f1179ac to
8e6f2ff
Compare
🔴 Tier 4 — CriticalTouches authentication, tenancy data models, the public API or shipped database config — or substantially changes the query rendering engine, background tasks, the OTel pipeline, image build, or release CI. Why this tier:
Review process: Deep review from a domain expert. Synchronous walkthrough may be required. Stats
|
Duplicate code analysisNo new duplicate code introduced by this PR. jscpd compared this branch against |
E2E Test Results✅ All tests passed • 398 passed • 1 skipped • 1352s
Tests ran across 4 shards in parallel. |
8e6f2ff to
e9f326d
Compare
e9f326d to
bb5395b
Compare
Summary
Adds support for series-mode heatmaps to the dashboards external api and MCP.
Screenshots or video
How to test locally
References