Repository navigation
feat: Support single-select dashboard filters #3295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| --- | ||
| '@hyperdx/common-utils': patch | ||
| '@hyperdx/api': patch | ||
| '@hyperdx/app': patch | ||
| --- | ||
|
|
||
| feat: Allow configuring dashboard filters as single-select |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -255,6 +255,14 @@ export const DashboardFilterEditForm = ({ | |
| {showRequiredFilterOptions && ( | ||
| <Stack gap="xs"> | ||
| <Divider my="xs" /> | ||
| <CheckBoxControlled | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🔵 minor — Single-select checkbox sits behind The prop doc at line 69-70 (and in Advisory. Fix if it is a small defect in code this PR changes; otherwise reply in the thread. Do not widen the PR or touch files it did not already change. How to respond |
||
| control={control} | ||
| name="isSingleSelect" | ||
| size="xs" | ||
| label="Single select" | ||
| description="Only one value can be selected at a time." | ||
| data-testid="filter-single-select-checkbox" | ||
| /> | ||
| <CheckBoxControlled | ||
| control={control} | ||
| name="isRequired" | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.