Repository navigation
feat: Support series limit on PromQL time charts #3294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| --- | ||
| '@hyperdx/app': patch | ||
| --- | ||
|
|
||
| feat: support a series limit on PromQL line, stacked bar, pie and bar charts | ||
|
|
||
| The Display Settings drawer now offers Series Limit for PromQL charts. On line and stacked bar charts it keeps the top N series by peak value (leave empty for the default of 250, or set 0 for unlimited). On pie and bar charts it keeps the N largest slices or bars (leave empty to show all). |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -267,6 +267,7 @@ export function convertFormStateToSavedChartConfig( | |
| 'fillNulls', | ||
| 'alignDateRangeToGranularity', | ||
| 'alternateRowBackground', | ||
| 'seriesLimit', | ||
| // 'alert', // TODO: Support alerts on PromQL (HDX-4636) | ||
| ]), | ||
| promqlExpression: formPromqlExpressions(form), | ||
|
|
@@ -366,6 +367,7 @@ export function convertFormStateToChartConfig( | |
| 'fillNulls', | ||
| 'alignDateRangeToGranularity', | ||
| 'alternateRowBackground', | ||
| 'seriesLimit', | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🔵 minor — Changing the client-side PromQL Series Limit re-runs the Prometheus query
Advisory. Fix if it is a small defect in code this PR changes; otherwise reply in the thread. Do not widen the PR or touch files it did not already change. How to respond |
||
| ]), | ||
| promqlExpression: formPromqlExpressions(form), | ||
| connection: source?.connection ?? form.connection ?? '', | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.