Repository navigation
feat: Support stacked line charts - #3290
Conversation
🦋 Changeset detectedLatest commit: ad4a345 The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Duplicate code analysisNo new duplicate code introduced by this PR. jscpd compared this branch against |
|
E2E Test Results✅ All tests passed • 399 passed • 1 skipped • 1535s
Tests ran across 4 shards in parallel. |
c0ab6cb to
d648f13
Compare
🔴 Tier 4 — CriticalTouches authentication, tenancy data models, the public API or shipped database config — or substantially changes the query rendering engine, background tasks, the OTel pipeline, image build, or release CI. Why this tier:
Additional context: touches background tasks or the delivery pipeline lightly (7 lines, under the 30-line bar for Tier 4), touches the query rendering engine lightly (5 lines, under the 150-line bar for Tier 4) Review process: Deep review from a domain expert. Synchronous walkthrough may be required. Stats
|
PR Review
2 finding(s): 🔴 0 critical · 🟠 0 major · 🔵 2 minor 1 posted as inline comment(s) on the changed lines. 1 listed below. Findings outside the changed lines1 minor
Severity is the reviewer's own estimate and is used for ordering, not filtering. No finding blocks merge automatically; a maintainer decides. |
Deep Review✅ No critical issues found. This is a clean, additive feature. The new 🟡 P2 -- recommended
🔵 P3 nitpicks (5)
Reviewers (11): correctness, adversarial, testing, maintainability, project-standards, api-contract, reliability, kieran-typescript, previous-comments, agent-native, learnings-researcher. Testing gaps:
No finding blocks merge automatically. A maintainer will expect P0/P1 findings in code this PR changes to be fixed; P2/P3 are your call -- fix or reply. Never fix findings about surrounding code here; reply instead. Do not widen the PR. How to respond |
d648f13 to
7b2aace
Compare
This comment has been minimized.
This comment has been minimized.
7b2aace to
0927f7a
Compare
knudtty
left a comment
There was a problem hiding this comment.
Approving with question:
In order for IaC to use this, do we need to update the terraform provider?
| return { errors, warnings }; | ||
| } | ||
|
|
||
| /** Maps the time-series display type names used by the external API and v1 chart configs. */ |
There was a problem hiding this comment.
🔵 minor — TIME_SERIES_DISPLAY_TYPE_BY_NAME and isTimeSeriesDisplayType list the same set separately and must be kept in sync by hand
Derive the predicate from the map, e.g. Object.values(TIME_SERIES_DISPLAY_TYPE_BY_NAME).includes(displayType), so the set has one source of truth. Callers such as packages/api/src/mcp/tools/dashboards/validation.ts:122 (displayType in TIME_SERIES_DISPLAY_TYPE_BY_NAME) and ChartUtils.convertV1ChartConfigToV2 check membership through the map, while every other caller goes through isTimeSeriesDisplayType. A future time-series type added to only one of the two will make those code paths disagree.
Advisory. Fix if it is a small defect in code this PR changes; otherwise reply in the thread. Do not widen the PR or touch files it did not already change. How to respond
Good question - no we should not need to |
Summary
This PR introduces a stacked_line display type, which (like stacked_bar) is a sub-type of time series display type.
In the CLI, these are rendered as stacked bar charts, because the stacking/fill doesn't look clear in the CLI, and stacked_bar is nearly the same display anyway.
Screenshots
Testing
References
Closes HDX-5376