Repository navigation
fix: cast FixedString haystacks before implicit hasToken search #3271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
kodiakhq
merged 11 commits into
ClickHouse:main
from
milansanjeev:fix/implicit-search-fixedstring-hastoken
Oct 5, 2026
+355
−2
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
0b81825
fix: cast FixedString haystacks before implicit hasToken search
milansanjeev a41de8f
fix: keep FixedString text indexes on hasAllTokens
milansanjeev dd73717
Merge branch 'main' into fix/implicit-search-fixedstring-hastoken
milansanjeev 8d294e5
Merge branch 'main' into fix/implicit-search-fixedstring-hastoken
milansanjeev 2ba5c06
Merge branch 'main' into fix/implicit-search-fixedstring-hastoken
milansanjeev d678fe0
Merge branch 'main' into fix/implicit-search-fixedstring-hastoken
milansanjeev 9613c2f
Merge branch 'main' into fix/implicit-search-fixedstring-hastoken
milansanjeev 6dcd370
Merge branch 'main' into fix/implicit-search-fixedstring-hastoken
milansanjeev 8d2b55c
Merge branch 'main' into fix/implicit-search-fixedstring-hastoken
milansanjeev d5aa218
Merge branch 'main' into fix/implicit-search-fixedstring-hastoken
pulpdrew b4d99d5
Merge branch 'main' into fix/implicit-search-fixedstring-hastoken
kodiakhq[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| --- | ||
| '@hyperdx/common-utils': patch | ||
| '@hyperdx/api': patch | ||
| '@hyperdx/app': patch | ||
| --- | ||
|
|
||
| fix: cast FixedString columns before implicit hasToken search | ||
|
|
||
| A bare search term against a FixedString column such as OTel TraceId compiled to | ||
| hasToken(lower(TraceId), ...), which ClickHouse rejects. Those haystacks are now | ||
| CAST to String first. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.