Repository navigation
refactor: Split up DBHeatmap into smaller, focused files; Add tests - #3256
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
🔴 Tier 4 — CriticalTouches authentication, tenancy data models, the public API or shipped database config — or substantially changes the query rendering engine, background tasks, the OTel pipeline, image build, or release CI. Why this tier:
Review process: Deep review from a domain expert. Synchronous walkthrough may be required. Stats
|
Duplicate code analysisNo new duplicate code introduced by this PR. jscpd compared this branch against |
PR Review
3 finding(s): 🔴 0 critical · 🟠 0 major · 🔵 3 minor 3 posted as inline comment(s) on the changed lines. Severity is the reviewer's own estimate and is used for ordering, not filtering. No finding blocks merge automatically; a maintainer decides. |
Deep ReviewPure refactor splitting the 1446-line ✅ No critical issues found. 🟡 P2 — recommended
🔵 P3 nitpicks (9)
Reviewers (10): correctness, testing, maintainability, project-standards, agent-native, learnings-researcher, performance, kieran-typescript, julik-frontend-races, previous-comments. Testing gaps:
No finding blocks merge automatically. A maintainer will expect P0/P1 findings in code this PR changes to be fixed; P2/P3 are your call -- fix or reply. Never fix findings about surrounding code here; reply instead. Do not widen the PR. How to respond |
E2E Test Results✅ All tests passed • 393 passed • 1 skipped • 1347s
Tests ran across 4 shards in parallel. |
|
Summary
This PR splits the monolithic Heatmap component into several composable files, and improves test coverage (including with new E2E tests).
No behavior changes are expected, this is a pure refactor.
Motivation: subsequent PRs are going to extend Heatmap support to new use-cases (non-trace sources, raw SQL and PromQL).
Screenshots or video
How to test on Vercel preview
References