Repository navigation
feat: add optional NEXT_PUBLIC_INSTANCE_LABEL suffix to brand name #3250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
b69d25b
a54727f
b5faf7b
9c76c83
6a7e5bb
ebd4ada
281ce4e
ab650fa
b6da722
320bb23
e018165
8a6959f
d9fbfc4
7343e1e
02dd79d
223a717
f745794
b31ecf9
261ccb8
70f0be1
c0da581
43dbb15
e542aba
8caf5ba
881cd36
d56d920
01e667f
c0a220d
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| --- | ||
| '@hyperdx/app': patch | ||
| --- | ||
|
|
||
| feat: add optional `NEXT_PUBLIC_INSTANCE_LABEL` suffix to the tab title and sidebar | ||
|
|
||
| Operators running multiple HyperDX instances (e.g. one per region) can now set `NEXT_PUBLIC_INSTANCE_LABEL` to append a short label to the browser tab title and sidebar, e.g. "HyperDX UK". Empty by default, no behavior change if unset. The sidebar label only shows when the sidebar is expanded, and replaces the UTC badge there when both are set. |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -13,6 +13,7 @@ import { | |
| } from '@mantine/core'; | ||
| import { useQuery } from '@tanstack/react-query'; | ||
|
|
||
| import { INSTANCE_TITLE_SUFFIX } from '@/config'; | ||
| interface GreenhouseJob { | ||
| id: number; | ||
| title: string; | ||
|
|
@@ -91,7 +92,7 @@ export default function CareersPage() { | |
| return ( | ||
| <Container size="md" py="xl"> | ||
| <Head> | ||
| <title>Careers | HyperDX</title> | ||
| <title>{`Careers | HyperDX${INSTANCE_TITLE_SUFFIX}`}</title> | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🔵 minor — CareersPage builds its title by hand with Use Advisory. Fix if it is a small defect in code this PR changes; otherwise reply in the thread. Do not widen the PR or touch files it did not already change. How to respond
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Intentional — Careers is about jobs at HyperDX the company, so it should keep saying "HyperDX" even on a white-labeled instance, not switch to the active theme's brand name.
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🔵 minor — CareersPage builds the brand+suffix title by hand instead of using the new usePageTitle hook Use Advisory. Fix if it is a small defect in code this PR changes; otherwise reply in the thread. Do not widen the PR or touch files it did not already change. How to respond
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Intentional — Careers is about jobs at HyperDX the company, so it should keep saying "HyperDX" even on a white-labeled instance, not switch to the active theme's brand name.
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🔵 minor — CareersPage hardcodes 'HyperDX' and the suffix instead of using usePageTitle Either leave this title alone (it is a HyperDX-company careers page, so a deployment's instance label doesn't belong in it) or use Advisory. Fix if it is a small defect in code this PR changes; otherwise reply in the thread. Do not widen the PR or touch files it did not already change. How to respond |
||
| </Head> | ||
| <Stack gap="lg"> | ||
| <Title order={1}> | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔵 minor — Login/Sign up tab title order flips from 'HyperDX - Login' to 'Login - HyperDX'
The changeset describes the change as appending a suffix with no other effect when unset, but it also reorders the auth titles and switches several pages'
–separator to-(e2e DashboardPage.ts had to be updated for this). Either mention this in the changeset or keep these out of this PR. Nothing else checks the auth title (grep for toHaveTitle finds only DashboardPage.ts), so this is a documentation gap, not a test break.Advisory. Fix if it is a small defect in code this PR changes; otherwise reply in the thread. Do not widen the PR or touch files it did not already change. How to respond