Repository navigation
feat: Filter and select sources by language and display type - #3185
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🦋 Changeset detectedLatest commit: 99780c6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
🟡 Tier 3 — StandardIntroduces new logic, modifies core functionality, or touches areas with non-trivial risk. Why this tier:
Review process: Full human review — logic, architecture, edge cases. Stats
|
|
Deep Review✅ No critical (P0/P1) issues found. The change is well-scoped, and the source-compatibility logic ( 🟡 P2 — recommended
🔵 P3 nitpicks (2)
Reviewers (10): correctness, adversarial, frontend-races, kieran-typescript, testing, maintainability, project-standards, previous-comments, agent-native, learnings-researcher. Testing gaps: The auto-select/auto-submit effect choreography (including the stale/duplicate-submission race on async source load) is exercised only by e2e, with no unit or hook-level test asserting single-submission behavior after a display-type change. No finding blocks merge automatically. A maintainer will expect P0/P1 findings in code this PR changes to be fixed; P2/P3 are your call -- fix or reply. Never fix findings about surrounding code here; reply instead. Do not widen the PR. How to respond |
c408d57 to
ee29833
Compare
E2E Test Results✅ All tests passed • 385 passed • 1 skipped • 1461s
Tests ran across 4 shards in parallel. |
PR Review
2 finding(s): 🔴 0 critical · 🟠 0 major · 🔵 2 minor 2 posted as inline comment(s) on the changed lines. Severity is the reviewer's own estimate and is used for ordering, not filtering. No finding blocks merge automatically; a maintainer decides. |
ee29833 to
f62f986
Compare
f62f986 to
123c746
Compare
|
This PR currently has a merge conflict. Please resolve this and then re-add the |
Duplicate code analysisNo new duplicate code introduced by this PR. jscpd compared this branch against |
Summary
This PR updates the chart editor so that
This helps avoid query errors and error states caused by invalid sources being selected when switching between config and display types. It also reduces user confusion from showing incompatible sources in the list of selectable sources.
Screenshots or video
Before
Screen.Recording.2026-09-22.at.11.32.41.AM.mov
After
Screen.Recording.2026-09-22.at.11.29.51.AM.mov
How to test on Vercel preview
Try navigating around the chart editor, varying source kind, display type, and editor type (sql, promql, builder)
References