Repository navigation
refactor(app): name the duration-heatmap number format #3182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
alex-fedotyev
wants to merge
1
commit into
main
Choose a base branch
from
alex/duration-heatmap-format
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔵 minor — The dashboard heatmap editor still builds its own copy of the
{ output: 'duration', factor: 0.001 }literalIn
applyHeatmapDefaults(packages/app/src/components/DBEditTimeChartForm/EditTimeChartForm.tsx:164), replace the inline{ output: 'duration', factor: 0.001 }withDURATION_HEATMAP_NUMBER_FORMAT. That function is the other duration heatmap, and it gets its value fromgetDurationMsExpression(lines 696 and 735), so after this PR the pairing lives in two places. While there: the Heatmap display-type switch at line 701 also passesfallbackValue, an arbitrary non-ms expression, intoapplyHeatmapDefaults. That path still gets the 0.001 factor, which the new doc comment says is wrong. Apply the format only when the value came fromgetDurationMsExpression, asDBSearchHeatmapChartdoes.Advisory. Fix if it is a small defect in code this PR changes; otherwise reply in the thread. Do not widen the PR or touch files it did not already change. How to respond
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Leaving both here.
EditTimeChartForm.tsxis outside this PR's files and routing it through the constant is the kind of extra call site this change should not reach for; thefallbackValuepath applying the ms factor to a non-ms expression is a real bug but it predates this PR, which only moves an existing literal. Worth its own change.