Repository navigation
feat: Support sparkline on promql number charts - #3178
Conversation
🦋 Changeset detectedLatest commit: 7e621ce The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Deep Review✅ No critical issues found. The core design is sound. The single-request optimization — where a PromQL number tile's value (reducer applied) and its background sparkline (no reducer) reuse one react-query cache entry — was verified directly: The prior Greptile "Alignment Changes Number Values" thread was re-examined: alignment is applied only to range queries, where expanding to complete bucket boundaries is intentional and consistent with existing timeseries-chart alignment. The original reporter withdrew the finding, and the current code matches that model — no unaddressed correctness regression remains. 🟡 P2 — recommended
🔵 P3 nitpicks (1)
Pre-existing (not counted toward verdict)
Reviewers (3 + orchestrator): maintainability, project-standards, learnings-researcher, plus orchestrator correctness/performance verification of the shared-cache design. Coverage note: The remaining dispatched reviewers (correctness, adversarial, testing, performance, api-contract, kieran-typescript, julik-frontend-races, previous-comments, agent-native) had not returned results within this run's synthesis window; the correctness, performance, and prior-comment dimensions they target were covered directly by orchestrator verification against the source. No standards violations were introduced (changeset present and correct; cross-package imports and test placement conform). Testing gaps: No test guards that No finding blocks merge automatically. A maintainer will expect P0/P1 findings in code this PR changes to be fixed; P2/P3 are your call -- fix or reply. Never fix findings about surrounding code here; reply instead. Do not widen the PR. How to respond |
ea33d8e to
e4e0448
Compare
PR Review
4 finding(s): 🔴 0 critical · 🟠 0 major · 🔵 4 minor 3 posted as inline comment(s) on the changed lines. 1 listed below. Findings outside the changed lines1 minor
Severity is the reviewer's own estimate and is used for ordering, not filtering. No finding blocks merge automatically; a maintainer decides. |
e4e0448 to
86ec2d5
Compare
E2E Test Results✅ All tests passed • 287 passed • 1 skipped • 953s
Tests ran across 4 shards in parallel. |
86ec2d5 to
9fc2ace
Compare
🟡 Tier 3 — StandardIntroduces new logic, modifies core functionality, or touches areas with non-trivial risk. Why this tier:
Review process: Full human review — logic, architecture, edge cases. Stats
|
Duplicate code analysis1 new clone introduced by this PR.
If one of these duplicates a helper that already exists, import it instead jscpd compared this branch against |
Summary
Support sparklines for PromQL number charts. Sparklines are supported only for range queries, where the Sparkline can re-use the results range query that was already fetched and reduced for the number.
Further, range number queries are now aligned to the dashboard's time range and granularity, like timeseries charts would be, since a range query is bucketing similar to how a timeseries query would be. This has the added benefit of allowing the sparkline query to re-use the same query results.
Screenshots or video
Screen.Recording.2026-09-22.at.8.56.00.AM.mov
How to testlocally
References