Repository navigation
fix(app): apply the clicked series' WHERE to a chart's Search action #3174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
MikeShi42
wants to merge
4
commits into
main
Choose a base branch
from
cursor/hdx-5441-chart-search-series-where-9e86
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
27f436e
fix(app): apply the clicked series' WHERE to a chart's Search action
cursoragent e11a73b
test(app): type the resolveSeriesConditionFilter fixtures instead of …
cursoragent 3ac15df
Merge remote-tracking branch 'origin/main' into cursor/hdx-5441-chart…
cursoragent 2ce2db9
docs(app): note mixed-language series fall back to an unscoped search
cursoragent File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| --- | ||
| '@hyperdx/app': patch | ||
| --- | ||
|
|
||
| fix: carry the clicked series' WHERE condition into a chart's Search action | ||
|
|
||
| A builder chart keeps each series' filter in its own `aggCondition`, not in the | ||
| statement-level `where`, so a drill-down built from chart-level state alone | ||
| spanned every series and its counts didn't reconcile with the clicked line. The | ||
| per-series Search now ANDs that series' condition onto the search, and "View all | ||
| events" carries the union of every series' condition (the scan scope the chart | ||
| itself used). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When a whole-bucket, ratio, or formula action falls back to all series and those series use different condition languages,
aggConditionScopeFilterreturnsundefined, so the Search URL drops every series condition. The chart query still renders each condition in its own language and ORs them together. The resulting search is therefore broader than the chart, and its results will not reconcile with the chart.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Accurate, but not something this PR introduced or can fix here. On
mainevery drill-down drops all series conditions, so this case is no worse than before. The per-series Search is unaffected: a single clicked series has one language.The search URL can't express the OR: it carries one
wherelanguage and ANDs itsfilters. Turning Lucene into SQL needs async column metadata, and adding an OR mode to the search page's filters would also change how its sidebar filters combine. So the fallback leaves the search unscoped (a superset of the chart's rows) rather than scoped wrongly. I documented that inresolveSeriesConditionFilterand added tests for both the mixed-language fallback and a clicked series in a mixed-language chart (2ce2db9).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed. The mixed-language whole-bucket fallback is a pre-existing limitation of the search URL/filter model, and this change preserves the existing unscoped behavior when the union cannot be represented. The per-series path remains correctly scoped because it resolves a single condition and therefore a single filter language. The documentation and tests cover this tradeoff, so no change is needed for this PR.