rft: cleanup from #681

[haakon-e]

I'm sorry you had to suffer through the previous PR @trontrytel. This is mostly deleting things you noted. I will follow up with some proper docs after I land the enormous stack of PRs that I'm sure you've noticed I opened.

content:

• rename f23_deposition_rate -> deposition_rate
• rename f23_immersion_limit_rate -> immersion_limit_rate
• delete AbstractINPDepletion abstract type
• removed nonsensical comments
• trimmed verbose "docs-like" code comments.
  Follow-up: proper user/developer docs
• removed references to internal notes
• added TODOs for follow-up work

[trontrytel]

No worries. I just figured that the least I can do with the previous PR is to understand the comments and docs, so that I know where to look for more info when I need it. And then I got derailed ;)

[haakon-e]

so that I know where to look for more info when I need it.

nono. keeping it opaque is what keeps me employed

[trontrytel]

so that I know where to look for more info when I need it.

nono. keeping it opaque is what keeps me employed

Are you quoting from Claude user manual?

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.67%. Comparing base (ea430c0) to head (09d92b0).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #736      +/-   ##
==========================================
- Coverage   92.74%   92.67%   -0.07%     
==========================================
  Files          56       56              
  Lines        2701     2676      -25     
==========================================
- Hits         2505     2480      -25     
  Misses        196      196              

Components	Coverage Δ
src	93.52% <100.00%> (-0.07%)	⬇️
ext	69.47% <ø> (ø)

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[haakon-e]

This change is part of the following stack:

• rft: cleanup from #681 #736 ◀
  • Make the pointwise 2M+P3 tendencies ForwardDiff-differentiable #725
    • feat(Rosenbrock): unified RosenbrockAverage substepping framework + 2M+P3 exact-AD mode #726
      • feat(Rosenbrock): 1M donor / coupled / exact modes on the unified framework #731
        • feat(Rosenbrock): post-solve per-process verbose diagnostics #732
          • fix(Rosenbrock): saturation adjustment on max(S_ice, S_liq) #737
            • Make the quadrature scheme the configuration choice #728
              • Re-add diagnostic-Nc activation for the 2M scheme #729

_{Change managed by git-spice.}

[trontrytel]

Do you have a PR in ClimaParams for this? If we are just changing the value, it should not be a breaking release. And we should be able to get it in quicklu

[haakon-e]

fixing in CliMA/ClimaParams.jl#295

[trontrytel]

Thank you!

[haakon-e]

This change is part of the following stack:

• rft: cleanup from #681 #736 ◀
  • Make the pointwise 2M+P3 tendencies ForwardDiff-differentiable #725

_{Change managed by git-spice.}