Update to ClimaOcean 0.10.0#1971
Conversation
|
It looks like with the new interface, we can't pass the model clock for the ocean or sea ice models to use anymore. In main it gets passed to We now call:
The only function in this callstack that exposes the I didn't trace through the callstack for the sea ice model but it has the same issue. The fix would be to open PRs in NumericalEarth and ClimaOcean to expose the clock arg for the functions listed above, as well as the corresponding functions for the sea ice model. For now I switched all the CMIP models to use float time ( |
eebcdff to
5f0d6f7
Compare
|
I got this to a point where the ocean simulation can be constructed successfully. Now it fails when trying to access the sea ice artifact: The fix that was applied in ClimaOcean here needs to be moved over into NumericalEarth.jl. After that's resolved, we may need to make more changes in the sea ice setup here, or in ClimaOcean/NumericalEarth/ClimaSeaIce, but we'll have to re-run CMIP to see. |
The corresponding PR in NumericalEarth for the sea-ice dataset is here |
| # Set up ocean grid (1 degree) | ||
| resolution_points = (360, 160, 32) | ||
| Nz = last(resolution_points) | ||
| depth = 4000 # meters |
There was a problem hiding this comment.
The vertical range of the NumericalEarth.DataWrangling.EN4.EN4Monthly() dataset (5500.0 m) is smaller than the target grid (6000.0 m). Some vertical levels cannot be filled with data.
(when using new default from CO.OceanConfigurations )
There was a problem hiding this comment.
We should initialize with WOAAnnual
|
Needs CliMA/ClimaAtmos.jl#4574 |
There was a problem hiding this comment.
Keep only CMIP runs (test only - revert before merge).
There was a problem hiding this comment.
Shortened for <12h turnaround : revert.
778819a to
376eae0
Compare
2) Update to use new regridder via ConservativeRegridding#0.2.5 3) Update to use tripolar ocean grid (1deg) 4) Temporarily disable ITime in CMIP until clock kwarg issues are resolved Co-authored-by: Simone Silvestri <silvestri.simone0@gmail.com> Co-authored-by: Akshay Sridhar <43710045+akshaysridhar@users.noreply.github.com> Co-authored-by: Julia Sloan <jsloan@caltech.edu>
376eae0 to
7c51613
Compare
ClimaOcean changed a lot recently, this PR is updating ClimaCoupler to use ClimaOcean 0.10.0