Add reset_fluxes! function to FluxCalculator#1908
Open
akshaysridhar wants to merge 1 commit into
Open
Conversation
juliasloan25
reviewed
May 7, 2026
juliasloan25
left a comment
juliasloan25
left a comment
Member
There was a problem hiding this comment.
Are you planning to extend this for the other components as part of this PR or in a followup?
| return nothing | ||
| end | ||
|
|
||
| function FluxCalculator.reset_fluxes!(sim::OceananigansSimulation) |
Member
There was a problem hiding this comment.
could you add a brief docstring please?
| """ | ||
| function update_model_sims!(model_sims, csf) | ||
| for sim in model_sims | ||
| FluxCalculator.reset_fluxes!(sim) |
Member
There was a problem hiding this comment.
I'm not sure how I feel about resetting the fluxes here. To me it would make a little more sense to do it explicitly in the coupler loop, after update_surface_fractions! and before exchange!. That way it's very clear what order things are done in rather than being tucked inside update_model_sims!.
akshaysridhar
force-pushed
the
as/generalize-flux-start
branch
from
945bf82 to
c0ece09
Compare
akshaysridhar
force-pushed
the
as/generalize-flux-start
branch
from
c0ece09 to
34a94e1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generalizes the flux reset in #1841. FluxCalculator now provides a
reset_fluxeshook which can be modified per model component.