Add space with multiple columns#2525
Open
ph-kev wants to merge 1 commit into
Open
Conversation
ph-kev
force-pushed
the
kp/multiple-columns
branch
6 times, most recently
from
7567810 to
e78f8a4
Compare
nefrathenrici
left a comment
nefrathenrici
left a comment
Member
There was a problem hiding this comment.
This looks good, I only saw a few immediate correctness issues.
ph-kev
force-pushed
the
kp/multiple-columns
branch
from
e78f8a4 to
02c2eb2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a space that can supports multiple columns. This is needed to complete CliMA/ClimaLand.jl#1723.
This PR have been tested with the
FluxnetSimulations in ClimaLand and it produces identical results with the current single column used for theFluxnetSimulation.The remapping feature will not be done in this PR. For the purpose of calibration, this is not needed because the data is extracted from the ClimaCore fields rather than from the NetCDF files produced from the diagnostics.
Note that most of the code in this PR have been written with Claude.