Use a Symmetric matrix in the Covariant Axis2Tensor#1828
Open
charleskawczynski wants to merge 1 commit into
Open
Use a Symmetric matrix in the Covariant Axis2Tensor#1828charleskawczynski wants to merge 1 commit into
charleskawczynski wants to merge 1 commit into
Conversation
af06f67 to
e3dee43
Compare
Member
Author
|
It looks like we'll need to generalize the |
fa21f52 to
30df952
Compare
30df952 to
9d00e24
Compare
Member
Author
|
I'm going to leave this open, as I'm still not convinced that I did this correctly. Also, I'm not sure if and how this works on the CUDA side. This sort of optimization could account for 12 scalar fields, which is a lot of additional memory to store (in the context of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the use of symmetric matrices for the Covariant Axis2Tensors.
I think that this should be all we need, and this may result in a nice improvement in our kernels that use these tensors.
I first tried to use
LinearAlgebra.Symmetric, however, it has auplo::Charfield, and this isn't a float type and as a result does not pass thecheck_basetype(T, S)test in our DataLayouts. So, I grabbed most of those definitions from LinearAlgebra and simply removeduplo.I did have to widen the allowable types in
AxisTensor.Closes #1827 (the
issymmetrictest fails on main without fixing #1827).