Skip to content

non-product upwinding#1367

Open
simonbyrne wants to merge 2 commits into
mainfrom
sb/upwinding-revamp
Open

non-product upwinding#1367
simonbyrne wants to merge 2 commits into
mainfrom
sb/upwinding-revamp

Conversation

@simonbyrne

@simonbyrne simonbyrne commented Jul 12, 2023

Copy link
Copy Markdown
Member

Fixes #1125.

  • Code follows the style guidelines OR N/A.
  • Unit tests are included OR N/A.
  • Code is exercised in an integration test OR N/A.
  • Documentation has been added/updated OR N/A.

@simonbyrne simonbyrne marked this pull request as draft July 12, 2023 21:25
@simonbyrne

simonbyrne commented Jul 12, 2023

Copy link
Copy Markdown
Member Author

bors try

bors Bot added a commit that referenced this pull request Jul 12, 2023
@bors
Try #1367:
dfce036
@bors

bors Bot commented Jul 12, 2023

Copy link
Copy Markdown
Contributor

try

Build failed:

@simonbyrne

simonbyrne commented Jul 12, 2023

Copy link
Copy Markdown
Member Author

bors try

bors Bot added a commit that referenced this pull request Jul 12, 2023
@bors
Try #1367:
f39b509
@bors

bors Bot commented Jul 12, 2023

Copy link
Copy Markdown
Contributor

try

Build failed:

@simonbyrne

simonbyrne commented Jul 12, 2023

Copy link
Copy Markdown
Member Author

bors try

bors Bot added a commit that referenced this pull request Jul 12, 2023
@bors
Try #1367:
5b1602d
@bors

bors Bot commented Jul 12, 2023

Copy link
Copy Markdown
Contributor

try

Build failed:

@simonbyrne

simonbyrne commented Jul 13, 2023

Copy link
Copy Markdown
Member Author

bors try

bors Bot added a commit that referenced this pull request Jul 13, 2023
@bors
Try #1367:
4f543b1
@bors

bors Bot commented Jul 13, 2023

Copy link
Copy Markdown
Contributor

try

Build failed:

@simonbyrne

simonbyrne commented Jul 13, 2023

Copy link
Copy Markdown
Member Author

bors try

bors Bot added a commit that referenced this pull request Jul 13, 2023
@bors
Try #1367:
ffa22e0
@bors

bors Bot commented Jul 13, 2023

Copy link
Copy Markdown
Contributor

try

Build failed:

@simonbyrne

simonbyrne commented Jul 13, 2023

Copy link
Copy Markdown
Member Author

bors try

bors Bot added a commit that referenced this pull request Jul 13, 2023
@bors
Try #1367:
291e6d0
@bors

bors Bot commented Jul 13, 2023

Copy link
Copy Markdown
Contributor

try

Build failed:

@simonbyrne

simonbyrne commented Jul 13, 2023

Copy link
Copy Markdown
Member Author

bors try

bors Bot added a commit that referenced this pull request Jul 13, 2023
@bors
Try #1367:
bcbbf47
@bors

bors Bot commented Jul 13, 2023

Copy link
Copy Markdown
Contributor

try

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@simonbyrne

simonbyrne commented Jul 13, 2023

Copy link
Copy Markdown
Member Author

bors try

@simonbyrne

simonbyrne commented Jul 13, 2023

Copy link
Copy Markdown
Member Author

bors try-

@simonbyrne simonbyrne force-pushed the sb/upwinding-revamp branch from ba84079 to efc543c Compare July 13, 2023 23:20
@simonbyrne

simonbyrne commented Jul 13, 2023

Copy link
Copy Markdown
Member Author

bors try

@simonbyrne simonbyrne marked this pull request as ready for review July 13, 2023 23:20
dennisYatunin
dennisYatunin reviewed Jul 14, 2023
View reviewed changes
Comment thread src/Operators/finitedifference/upwinding.jl Outdated
bors Bot added a commit that referenced this pull request Jul 14, 2023
@bors
Try #1367:
40a8b01
@bors

bors Bot commented Jul 14, 2023

Copy link
Copy Markdown
Contributor

try

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

charleskawczynski
charleskawczynski reviewed Jul 14, 2023
View reviewed changes

@charleskawczynski charleskawczynski left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there tests added for the new operator(s)? It's a bit hard to tell with the name changes squashed together. If not, maybe we can add them / convergence tests? Aside from that LGTM

@simonbyrne

simonbyrne commented Jul 14, 2023

Copy link
Copy Markdown
Member Author

Good point. I was relying on the implicit testing, but we should add some more

@simonbyrne simonbyrne force-pushed the sb/upwinding-revamp branch 2 times, most recently from 81187ca to 237fce1 Compare July 18, 2023 17:24
@simonbyrne

simonbyrne commented Jul 18, 2023

Copy link
Copy Markdown
Member Author

bors try

bors Bot added a commit that referenced this pull request Jul 18, 2023
@bors
Try #1367:
fe956be
@bors

bors Bot commented Jul 18, 2023

Copy link
Copy Markdown
Contributor

try

Build failed:

@simonbyrne simonbyrne force-pushed the sb/upwinding-revamp branch from 237fce1 to 224eb62 Compare July 18, 2023 18:48
@simonbyrne

simonbyrne commented Jul 18, 2023

Copy link
Copy Markdown
Member Author

bors try

bors Bot added a commit that referenced this pull request Jul 18, 2023
@bors
Try #1367:
335e07b
@bors

bors Bot commented Jul 18, 2023

Copy link
Copy Markdown
Contributor

try

Build failed:

@simonbyrne simonbyrne closed this Jul 18, 2023
@simonbyrne simonbyrne reopened this Jul 18, 2023
@simonbyrne simonbyrne force-pushed the sb/upwinding-revamp branch from 224eb62 to 6a00f21 Compare July 18, 2023 21:51
@simonbyrne simonbyrne force-pushed the sb/upwinding-revamp branch from 6a00f21 to 701f7ee Compare August 17, 2023 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@charleskawczynski charleskawczynski charleskawczynski left review comments

@dennisYatunin dennisYatunin dennisYatunin left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Non-product upwind reconstuction operators

3 participants

@simonbyrne @charleskawczynski @dennisYatunin