Add support for OutputVars with no time dimension#320
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #320 +/- ##
==========================================
+ Coverage 58.91% 59.35% +0.43%
==========================================
Files 17 17
Lines 1407 1422 +15
==========================================
+ Hits 829 844 +15
Misses 578 578 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
nefrathenrici
approved these changes
Jun 4, 2026
nefrathenrici
left a comment
nefrathenrici
left a comment
Member
There was a problem hiding this comment.
Looks correct, I just had a comment on the code duplication.
This was missed in this PR #318.
ph-kev
force-pushed
the
kp/no-time
branch
2 times, most recently
from
9925c59 to
cbe56a1
Compare
This commit also refactors the checks for the time dimension into a helper function.
It was implied that OutputVar passed to the `GEnsembleBuilder` has a time dimension.
nefrathenrici
approved these changes
Jun 8, 2026
nefrathenrici
left a comment
nefrathenrici
left a comment
Member
There was a problem hiding this comment.
This looks great. To make the Derecho pipeline work, could you update line 5 of .buildkite/derecho_pipeline.yml? It needs a GPU:
pbs_l_select: "1:ncpus=1:ngpus=1"
The Derecho pipeline could not run, because we ran out of CPU hours.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For
ObservationRecipeandEnsembleBuilder, there was an implicit assumption that calibration would always involve time series data. However, this may not always be the case. For example, instead of using the entire time series data, you may be interested in certain features of the time series data (e.g. where the minimum or maximum are or the amplitude if it is periodic data). This PR allows forOutputVars with no time dimension to be used with theGEnsembleBuilderandObservationRecipewithScalarCovariance.In the future, we may want to support
OutputVars with no time dimension for theSVDplusDCovarianceestimator, but this can be done in another PR.closes #267
TODO
covarianceandobservationinObservationRecipeforScalarCovariance