Skip to content

Add more reconstruct functions#319

Merged
ph-kev merged 1 commit into
mainfrom
kp/obs-utils
Jun 8, 2026
Merged

Add more reconstruct functions#319
ph-kev merged 1 commit into
mainfrom
kp/obs-utils

Conversation

@ph-kev

@ph-kev ph-kev commented May 28, 2026

Copy link
Copy Markdown
Member

While working on calibration in CliMA/ClimaAtmos.jl#4516, having the functionality to plot the ensemble from the G ensemble matrix and the g mean is helpful. This PR introduces reconstruct_g and reconstruct_g_mean which uses the metadata in the observations to reconstruct OutputVars.

TODO

  • Add tests for reconstruct_g and reconstruct_g_mean

@codecov

codecov Bot commented May 29, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 58.91%. Comparing base (998e50e) to head (38ab8dd).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #319      +/-   ##
==========================================
+ Coverage   58.50%   58.91%   +0.41%     
==========================================
  Files          17       17              
  Lines        1393     1407      +14     
==========================================
+ Hits          815      829      +14     
  Misses        578      578              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ph-kev ph-kev force-pushed the kp/obs-utils branch 2 times, most recently from 5dcdcee to 38ab8dd Compare May 29, 2026 23:55
@ph-kev ph-kev marked this pull request as ready for review May 30, 2026 00:01
@ph-kev ph-kev requested a review from nefrathenrici June 1, 2026 15:06

@nefrathenrici nefrathenrici left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I just had nitpick comments

Comment thread ext/observation_recipe.jl Outdated
Comment thread ext/observation_recipe.jl Outdated
Comment thread ext/observation_recipe.jl Outdated
Comment thread ext/observation_recipe.jl Outdated
Comment thread test/observation_recipe.jl Outdated
@ph-kev ph-kev merged commit 324a5f6 into main Jun 8, 2026
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants